support new Cursor attribute that provides information on completed commands

Abierto

#388 abierto el 25/4/2024 1 comentario 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad: 4/5
Tiempo estimado: 3-5 días
Aptitud para principiantes: 35/100

Tipo de issue: Nueva funcionalidad
Claridad: Bastante claro
Estado de actividad: Estancado
Stack tecnológico: python, sql
Área: databases

Línea de trabajo

Comienza con DatabricksConnectionManager.get_response() en dbt-databricks, donde el issue identifica el mensaje "OK" codificado de forma fija, e inspecciona el cursor del conector y el manejo de los resultados de los comandos. Compara la salida deseada con las etiquetas CommandComplete de PostgreSQL y los atributos del controlador indicados. Se considera terminado cuando los comandos completados exponen un atributo apropiado del cursor y get_response() informa de la operación y del número de filas afectadas.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

While a Cursor attribute providing SQL State Code is not officially a part of PEP 249: Python DB API 2.0 spec, it's a common enough convention and would greatly enhance the user experience of dbt-databricks users (👀 @benc-db)

Many database drivers provide this as a Cursor attribute, dbt was able to depend on these drivers to provide it for a ConnectionManager.get_response() method, which reports to users after successful queries the kind of operation performed (SELECT, INSERT, CREATE) and the numbers of rows affected.

However, this is not fully supported today in dbt-databrick, see DatabricksConnectionManager.get_response() where message is hardcoded as "OK" instead of returning more information.

Support for SQL state amongst popular analytics database drivers

Driver	`Cursor` attribute (docs)
psycopg2	`statusmessage`
`snowflake-connector-python`	`sqlstate`

Ideal implementation

Follow Postgres's CommandComplete message

Command	Tag	`rows` indicates the number of rows
`INSERT`	`INSERT 0 rows`	inserted
`DELETE`	`DELETE rows`	deleted
`UPDATE`	`UPDATE rows`	updated
`MERGE`	`MERGE rows`	inserted, updated, or deleted
`SELECT` / `CREATE TABLE AS`	`SELECT rows`	retrieved
`MOVE`	`MOVE rows`	ursor's position has been changed by
`FETCH`	`FETCH rows`	that have been retrieved from the cursor
`COPY`	`COPY rows`	copied, only in `PostgreSQL` 8.2 and later

Lenguaje dominante: Python
Estrellas: 233
Forks: 152
Merge medio: 21 h 5 min
PR fusionados (30 d): 10