Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Discussion/Proposal: Pitches always have accidentals

Abierto
  • ¿Algo no está bien?
#2,010 5 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
backend

Línea de trabajo

Start by reading the Pitch and Accidental implementation and their tests; the issue does not name specific files or tests. Assess how making every Pitch hold an Accidental affects construction, behavior, and performance, including the stated timing comparisons and the proposed terminology changes. Done would require an agreed proposal and corresponding updates, but this issue is a discussion rather than a scoped implementation task.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Similar in vein to #2009 (octave always exists):

Music21 started out with the goal of being able to represent many different ways of thinking about music, globally and historically. One of the things that I wanted to be able to represent was pitch ambiguity.

In a lot of the world's music, especially what I'm most familiar with, Medieval European music, there's a notion of a neutral pitch, like some B, which might be expressed as B-natural or B-flat, but which one is not specified, and tradition and context will determine which to sing. (Tradition and norms is, for instance, why the default B in England became B-natural, but the default B in Germany became B-flat...)

This is why music21 has the concept of Pitch.accidental is None -- it does not mean "don't show a natural" (that would be Pitch.accidental = Accidental('natural', displayType='never') ). It was intended to means that no accidental (sharp/natural/flat) had been applied to this not at all.

What a laudable goal, representing all this way of thinking about music.

Has anyone ever actually done this with music21 (outside some demos I gave ca. 2008)? No. Probably not. Has everyone who ever worked with music21 ever since had to deal with if p.accidental is None or p.accidental.name = 'natural':... -- yes. And has everyone who works with this just always treated None as meaning natural? Yes, surely.

Proposal

Every Pitch object gets an accidental object attached to it -- natural if not specified -- and .accidental will always refer to an Accidental object.

Is there a cost to this?

You bet. Pitches with naturals will take 50% longer to create than they currently do:

In [42]: %timeit pitch.Pitch('C4')
512 ns ± 10.5 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)

In [43]: %timeit pitch.Pitch('C#4')
750 ns ± 1.92 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)

this cascades down to Note, as a 17% slowdown:

In [48]: %timeit note.Note('C4')
1.56 μs ± 23.4 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)

In [49]: %timeit note.Note('C#4')
1.83 μs ± 6.06 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)

If Accidental had been made immutable like Microtone, then we might be able to get the cost down to near nothing, but instead we can try to make the speed up in other ways.

Like we might stop allowing 'SHARP' instead of 'sharp' or 'FLAT' instead of 'flat' -- save a few ns -- I think that .set() can also be sped up immediately using a one-time created lookup table instead of a bunch of if statements.

Proposal Part 2:

Remove non-standard terminology for half-sharp ~ and half-flat ` -- no one knows what they are and I think better to be explicit ("-half-flat") than obscure.

Lenguaje dominante
Python
Estrellas
2.6k
Forks
459
Merge medio
1 d 7 h
PR fusionados (30 d)
40

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de cuthbertLab/music21

Todos los issues de cuthbertLab/music21

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.