(BUG) Rotator Control Disengaging Due To Error Counter
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 22/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Estancado
- Stack tecnológico
- c
- Área
- desktop-dev
Línea de trabajo
Start with rot_ctrl_timeout_cb and the MAX_ERROR_COUNT check, then trace how gtk-rot-ctrl.c returns false from set_pos and get_pos on RPRT -5 errors. The reporter links commit b56d77d as the likely cause. Reproducing needs a rotctld or Yaesu GS-232B setup, so a simulated rotator is the practical route. Done means either the error counter no longer disengages intermittent timeouts, or a user option to disable auto-disconnect exists and is documented.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Gpredict: 2.3
OS: Ubuntu 16.04.4 LTS
Rotator Control: Yarsu G-5500 az-el rotator with the Yaesu GS-232B PC interface
Hi All,
We've noticed a bug where the engage button does not remain selected when trying to connect to use the rot controller. When using version 2.2.1, we see the following in the error log:
2022/07/19 13:44:58|3|sat_log_init: Session started
2022/07/19 13:44:58|4|sat_cfg_load: Everything OK.
2022/07/19 13:45:29|1|gtk-rot-ctrl.c:386: rotctld returned error -5 with az 92.963905 el 0.000000(RPRT -5)
2022/07/19 13:45:33|1|gtk-rot-ctrl.c:386: rotctld returned error -5 with az 92.963905 el 0.000000(RPRT -5)
2022/07/19 13:45:36|1|gtk-rot-ctrl.c:386: rotctld returned error -5 with az 92.963905 el 0.000000(RPRT -5)
2022/07/19 13:45:40|1|gtk-rot-ctrl.c:386: rotctld returned error -5 with az 92.963905 el 0.000000(RPRT -5)
2022/07/19 13:45:44|1|gtk-rot-ctrl.c:386: rotctld returned error -5 with az 92.963905 el 0.000000(RPRT -5)
However, when using a newer version, we see the following:
2022/07/19 13:48:52|3|sat_log_init: Session started
2022/07/19 13:48:52|4|sat_cfg_load: Everything OK.
2022/07/19 13:49:19|1|gtk-rot-ctrl.c:322: rotctld returned error (RPRT -5)
2022/07/19 13:49:33|1|gtk-rot-ctrl.c:385: rotctld returned error -5 with az 131.777359 el 0.000000(RPRT -5)
2022/07/19 13:49:37|1|gtk-rot-ctrl.c:1180: rotctld returned error -5 with stop-cmd (RPRT -5)
2022/07/19 13:49:38|1|gtk-rot-ctrl.c:385: rotctld returned error -5 with az 131.777359 el 0.000000(RPRT -5)
2022/07/19 13:49:45|1|gtk-rot-ctrl.c:322: rotctld returned error (RPRT -5)
2022/07/19 13:50:03|1|gtk-rot-ctrl.c:385: rotctld returned error -5 with az 92.999634 el 0.000000(RPRT -5)
2022/07/19 13:50:06|1|gtk-rot-ctrl.c:1180: rotctld returned error -5 with stop-cmd (RPRT -5)
2022/07/19 13:50:08|1|gtk-rot-ctrl.c:385: rotctld returned error -5 with az 92.999634 el 0.000000(RPRT -5)
2022/07/19 13:50:11|1|rot_ctrl_timeout_cb: MAX_ERROR_COUNT (5) reached. Disengaging device!
We believe the issue is associated with this commit, which has set_pos and get_pos return false when there is an issue with the rotator control, causing some error counter to reach its limit and disengage the control. In previous versions, these errors were simply logged and the rotator control was allowed to remain engaged.
The hamlib rotctld daemon message log contained the following:
read_string(): Timed out 0.400445 seconds after 0 chars
write_block(): TX 2 bytes
0000 53 0d S.
read_string(): Timed out 0.400619 seconds after 0 chars
write_block(): TX 2 bytes
0000 53 0d S.
read_string(): Timed out 0.400483 seconds after 0 chars
write_block(): TX 2 bytes
0000 53 0d S.
read_string(): Timed out 0.400576 seconds after 0 chars
rotctl(d): p '' '' '' ''
It is worth noting that these timeouts occur intermittently and do not prevent the useful operation of the rotator control. A possible solution to this might be to include an option to disable the auto-disconnect-on-error-count-maximum-exceeded “feature”.
Thanks all for any help on this issue.
- Lenguaje dominante
- C
- Estrellas
- 1.2k
- Forks
- 305
- Merge medio
- 8 h 48 min
- PR fusionados (30 d)
- 3
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de csete/gpredict
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
Dificultad 2/5 Menos de una hora Aptitud para principiantes 60/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
Dificultad 4/5 3-5 días Aptitud para principiantes 78/100
Todos los issues de csete/gpredict
Issues similares
-
mewencode: base256[] and base128[] are indexed out of bounds by a non-ASCII octetPosiblemente ocupada @kazu-yamamoto la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
kazu-yamamoto/Mew#276 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 91/100
FujiNetWIFI/fujinet-firmware#2045 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 75/100
gbdev/homebrewhub-submit#20 ·
-
pluto: extract.c logs cert nickname instead of ckaid when both *cert= and *ckaid= are specifiedPosiblemente ocupada @Yash990-bit la tomó hoy. Abierto
Dificultad 1/5 1-3 horas Aptitud para principiantes 70/100
Los mantenedores suelen responder en 2 días