🤖 Backup settings form: stale messages, field labels, and missing length limits

Abierto
  • ¿Algo no está bien?
#7,827 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
frontend

Línea de trabajo

The issue identifies the Backup settings form and its validation schema, but does not name their files or tests. Start by locating the Backup settings form and schema, then trace save-state messages and validation rules; add repro tests for the stale messages, excessive lengths, invalid repository URL, and subdirectory rules. Done means only the current-state message is shown and invalid values produce field-labelled errors explaining the violated rule.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

A bug bash of Settings > Backup (Sonnet 5.5, charter backup-validation) found these form problems. They predate #7826 and the backup symlink PRs.

  1. A failed save's error stays visible after the user corrects the field and the form shows "Unsaved changes".
  2. A stale "Backup settings saved." stays beside a new error, such as "Repository URL is required." and "Unsaved changes".
  3. A 300-character branch, a 300-character subdirectory, and the repository not a url all save. The schema has no length limits, and it does not check the repository URL shape.
  4. The subdirectory error names the schema key path, not the "Subdirectory" label. Its rule text, "Enter a subdirectory inside the repository", does not say that .. and absolute paths are refused.

Expected

The form shows only the message for its current state. It refuses values that git or the filesystem cannot use, and the message names the field label and the rule it breaks.

Evidence

This is explorer evidence (video and screenshots) from a local bug-bash run. Nobody has written a repro test for these yet.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $13.47

Lenguaje dominante
TypeScript
Estrellas
2.1k
Forks
139
Merge medio
4 h 38 min
PR fusionados (30 d)
926

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de coder/xum

Todos los issues de coder/xum

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.