Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

perf: skip redundant work in `RouteCollection::create()` during route registration

Abierto
  • ¿Algo no está bien?
#10,617 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
62/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
php
Área
backend, performance

Línea de trabajo

The work is in RouteCollection::create() in system/Router/RouteCollection.php. Read the placeholder str_ireplace loop and the helper('array') call there, then check how RouterTest.php and RouteCollectionTest.php in tests/system/Router/ exercise route keys. Done means the placeholder loop runs only when the key contains :, the array helper loads once per collection with the same side effect, and the existing route tables and the two new cases still pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

Without route caching, the route table is rebuilt on every request. Each $routes->get() (or post(), add(), and so on) runs RouteCollection::create(), which costs about 1.9 µs per route. That's about 8 times more than the worst-case cost of matching a route.

Two steps in create() do work that is usually wasted:

  • The placeholder loop. create() runs str_ireplace(':' . $tag, ...) once for every registered placeholder (6 by default), even when $from has no : and nothing can match. That costs about 0.50 µs per route.
  • helper('array'). It's called on every create(). RouteCollection no longer uses any array-helper function, but the call still loads the helper for the app as a side effect. Repeat calls cost about 0.24 µs per route.

Measurements

PHP 8.3 on macOS, OPcache on, production mode, warm. Config construction cost was turned off to approximate the state after #10615. The routes are a realistic mix: a third static, a third with one placeholder, a third with two, spread across groups.

Routes Build route table Match last route 404
30 78 µs 15 µs 11 µs
100 248 µs 32 µs 27 µs
300 608 µs 85 µs 79 µs
1000 2,030 µs 263 µs 252 µs

Here's the cost breakdown of one $routes->get() call:

Step Cost
esc(strip_tags($from)) 0.49 µs
Placeholder str_ireplace loop (6 placeholders) 0.50 µs
helper('array') 0.24 µs
Everything else ~0.6 µs
Total ~1.87 µs

Proposal

  1. In create(), run the placeholder loop only when the route key contains :. If it has no :, no str_ireplace can match, and no replacement can add a :. So the output is identical. That includes custom placeholders whose patterns contain :, such as (?:...).
  2. Call helper('array') only on the first create() of each collection, using a private flag. The helper still loads at the same point as today, so apps that quietly depend on it keep working. A short comment will explain that the call stays only for this side effect.

Estimated savings are about 0.74 µs per route, roughly 40% of the build cost:

  • 100 routes: about 75 µs per request
  • 1000 routes: about 0.75 ms per request

Compatibility

  • No change to public or protected APIs. The only new state is private.
  • The route table comes out the same: same keys, handlers, names, and options.
  • No changelog or upgrade-guide entry is planned.

Not changing

  • esc() stays in create(). Apps can replace esc() in app/Common.php, so skipping the call would quietly bypass a custom version on route paths. A faster esc() for the html context could be a separate issue.
  • The matcher (Router::checkRoutes()). A FastRoute-style matcher was prototyped. Without route caching, building its lookup structure on each request cost about as much as the linear scan it replaced. So the net gain was small at typical route counts.

Tests

Add cases to tests/system/Router/RouteCollectionTest.php that lock in today's behavior:

  • A route with no placeholders keeps its exact key.
  • A custom placeholder whose pattern contains (?:...), mixed with built-in placeholders, still expands correctly.

Run RouteCollectionTest.php and RouterTest.php.

Related

  • #10615: config construction cost
  • #10616: filter discovery cost
Lenguaje dominante
PHP
Estrellas
6k
Forks
2k
Merge medio
1 d 22 h
PR fusionados (30 d)
59

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de codeigniter4/CodeIgniter4

Todos los issues de codeigniter4/CodeIgniter4

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.