codeceptjs run-workers X can do with sequencing improvements

Abierto
#4,250 6 comentarios 2 reacciones 1 asignado Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

stale
What are you trying to achieve?

codeceptjs run-workers 5 should be more performant and pull tests from a pool instead of having each test pre-assigned to a thread

What do you get instead?

Currently run-workers will create a pool of all tests when codeceptjs run-workers 5 is executed.

It then pre-assigns each test to a CPU thread and starts running all tests assigned to each thread.

This creates an even distribution of tests per thread. The problem is that not all tests are equal in terms of runtime

Small sample from end of test execution

[01]   ✔ in 4354ms
[04]   ✔ in 4794ms
[02]   ✔ in 3328ms
[04]   ✔ in 7131ms
[03]   ✔ in 13437ms
[01]   ✔ in 11558ms
[05]   ✔ in 21881ms
[02]   ✔ in 7051ms
[02]   ✔ in 4259ms
[03]   ✔ in 15055ms
[02]   ✔ in 5372ms
[03]   ✔ in 5274ms
[03]   ✔ in 17304ms

If all tests in thread 1 would complete in 2 minutes, then thread 1 would not pick up any more tests even if thread 2 - 5 have 6 tests all still waiting in their queue. This means that tests are only as fast as the slowest thread rather than allowing tests to be picked up by an idle thread.

In the example above thread 02 and 03 were slower than others. thread 01, 04 and 05 were waiting in idle while 02 and 03 were continuing with their queue.

In an ideal world, thread 01, 04 or 05 would see this incomplete queue and pick up a task to speed up test performance.

Details
  • CodeceptJS version: 3.5.3
  • NodeJS Version: 18
  • Operating System: MacOS / Linux
  • puppeteer
Lenguaje dominante
JavaScript
Estrellas
4.2k
Forks
756
Merge medio
2 d 9 h
PR fusionados (30 d)
16

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de codeceptjs/CodeceptJS

Todos los issues de codeceptjs/CodeceptJS

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.