GitLab Repositories with dots result in wrong paths for the SARIF converter

Start at CodeQualityToGitlab/SarifConverters/Converter1.cs around line 87 and inspect how MakeRelativeUri handles a project path such as /builds/my_group/ns.myproject. Compare this behavior with the roslynator converter's root-path handling. Done means SARIF paths under project roots containing dots are converted to the correct relative paths.

https://github.com/codecentric/dotnet_gitlab_code_quality/blob/63ec7e8061f38fa65189dabde3aeb7d832e1257d/CodeQualityToGitlab/SarifConverters/Converter1.cs#L87

If the project path contains any dots, e.g.: /builds/my_group/ns.myproject the roslynator converter correctly transforms the root paths.

However the Sarif Converters make use of the MakeRelativeUri function, which will treat the string wrong.

I suggest using something more robust like

var uri = new Uri(pathRoot);
var absolutePath = begin.ResultFile.Uri.LocalPath;
var rootPath = uri.LocalPath;

if (absolutePath.StartsWith(rootPath))
{
   return absolutePath.Substring(rootPath.Length).Replace("//", "\\");
}

return begin.ResultFile.Uri.MakeRelativeUri(uri).ToString().Replace("//", "\\");

GitLab Repositories with dots result in wrong paths for the SARIF converter

Evaluación

Línea de trabajo

Descripción

Guía de contribución

Primeros pasos

Más de codecentric/dotnet_gitlab_code_quality

Issues similares

GitLab Repositories with dots result in wrong paths for the SARIF converter

Evaluación

Línea de trabajo

Descripción

Guía de contribución

Primeros pasos

Más de codecentric/dotnet_gitlab_code_quality

Issues similares

Recibe los nuevos issues en tu correo