test(tui): status_write_is_atomic_under_concurrent_reads fails on Windows with NotFound (rename over a file being read)
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
Línea de trabajo
Start with crates/atlas-tui/src/runtime/manager/health_check.rs around the failing test and trace write_status_atomic to atlas_core::fs::write_atomic. Then inspect the .tui-status.json readers used by atlas dev --status and the MCP status tools to see how they handle NotFound. Done means the Windows race is addressed consistently for the test and production readers.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What fails
atlas-tui runtime::manager::health_check::tests::status_write_is_atomic_under_concurrent_reads failed once on Windows with a NotFound from the reader:
FAIL [ 5.473s] (2651/3095) atlas-tui runtime::manager::health_check::tests::status_write_is_atomic_under_concurrent_reads
thread '<unnamed>' (968) panicked at crates\atlas-tui\src\runtime\manager\health_check.rs:653:66:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }
thread 'runtime::manager::health_check::tests::status_write_is_atomic_under_concurrent_reads' panicked at health_check.rs:664:31:
called `Result::unwrap()` on an `Err` value: Any { .. }
Evidence: run 44087317372 (a throwaway workflow_dispatch matrix, 2026-11-17), job 134053020665, windows-2022 (image 20261112.366.7), runner GitHub Actions 1000025870, Test step of commit 8019de2f-based branch; 1 failure in 10 jobs of that run (the other 9, 5 of them on windows-2025-vs2026, passed). Not a runner loss: the step ended normally with 3094 passed, 1 failed.
Why it fails
The test has one thread rewrite .tui-status.json 300 times with write_status_atomic (atlas_core::fs::write_atomic: temp file + sync_all + fs::rename over the target) while another thread loops std::fs::read_to_string(path).unwrap() and expects the old or the new content, "never a partial file". On Windows the rename over an existing file that a reader has just opened or is opening can make the target momentarily not resolvable, so the reader gets NotFound (os error 2), which the test's .unwrap() turns into a panic. The Unix rename(2) never has that window.
Why it matters beyond the test
If the cause is the rename, any Windows reader of .tui-status.json (the atlas dev --status / MCP status tools read it while the runner rewrites it) can see a transient NotFound and may report "atlas dev is not running" for an instant. Worth checking the readers' handling together with the fix.
Not done here
No fix attempted (asked to file it). Candidates: make the test retry on NotFound (what the fix of #484/#485 did for similar fsync-speed races) only if the readers in production already tolerate it, or make write_atomic robust on Windows (ReplaceFileW, or a retry of the open in the shared reader).
Found while investigating #520 (runner losses); unrelated to them.
- Lenguaje dominante
- Rust
- Estrellas
- 3
- Forks
- 1
- Merge medio
- 9 h 51 min
- PR fusionados (30 d)
- 310
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de codeatlasdev/atlas
-
type: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
codeatlasdev/atlas#597 ·
Los mantenedores suelen responder en 1 día
-
area: ci os: linux type: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
codeatlasdev/atlas#496 ·
Los mantenedores suelen responder en 1 día
-
area: ci type: bug
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
codeatlasdev/atlas#596 ·
Los mantenedores suelen responder en 1 día
-
os: linux type: bug
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
codeatlasdev/atlas#591 ·
Los mantenedores suelen responder en 1 día
-
flaky: Windows scripts job hits test timeouts (check-dco, i18n runner/translate, check-changed)Abiertoarea: ci os: windows type: bug
Dificultad 3/5 1-2 días Aptitud para principiantes 56/100
codeatlasdev/atlas#550 · 1 comentario ·
Los mantenedores suelen responder en 1 día
Todos los issues de codeatlasdev/atlas
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
tinystream-dev/tinystream#132 ·
-
contract good first issue testing
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Emmyt24/nova-launch#2436 ·
Los mantenedores suelen responder en 1 día