Terminal Phase 1 [Windows]: own ConPTY layer in atlas-host with bundled OpenConsole

Abierto
#240 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
10/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust
Área
desktop

Línea de trabajo

Read discussion #237 and the Phase 0 probe first, then the existing Windows path that portable-pty replaces before touching crates/atlas-host/src/pty/conpty.rs. The work spans loader flags, IOCP-backed overlapped pipes, close ordering, installer bundling and a self-test fallback ladder, so start by reproducing the Phase 0 matrix measurements on a Win10 1809 box. Done means no throughput regression, byte-exact DCS/sixel/kitty output, and no hangs on resize, mouse or close.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: terminal priority: 1 high status: confirmed type: feature

Part of the native GPU terminal roadmap. Design and evidence: discussion #237. Uses the Phase 0 probe.

Why

Win10 never gets ConPTY fixes (microsoft/terminal discussion #17608); only the redistributable Microsoft.Windows.Console.ConPTY (MIT, 17763+) brings the #17510 passthrough (DCS, sixel, kitty APC, ordered sync output, mouse). portable-pty 0.9 and alacritty_terminal load conpty.dll by bare name (DLL planting), have no overlapped pipes, no ReleasePseudoConsole, and cannot set GLYPH_WIDTH_GRAPHEMES.

Change

  • crates/atlas-host/src/pty/conpty.rs over windows-sys, replacing portable-pty on Windows only.
  • LoadLibraryExW(<exe dir>\\conpty.dll, LOAD_LIBRARY_SEARCH_APPLICATION_DIR); resolve ConptyCreate/Resize/Close/ReleasePseudoConsole; kernel32 fallback.
  • Flags: GLYPH_WIDTH_GRAPHEMES, never INHERIT_CURSOR. Release right after CreateProcess.
  • Output: overlapped named pipe, one IOCP reader for all PTYs in hostd. Input stays synchronous until overlapped input is proven on 1809.
  • Close order: drop writer → Close off the reader thread → drain to EOF → join (close blocks before Win11 24H2).
  • Ship a pinned stable pair (x64 + arm64) in the NSIS installer with licence notices; deliberate updates.
  • First-use self-test (10 MB burst + DSR) picks bundled vs inbox per machine; setting terminal.conpty = auto | bundled | system.
  • Fallback ladder: bundled → inbox → xterm.js.

Done when

On the Phase 0 matrix: no throughput regression vs inbox; DCS/sixel/kitty bytes byte-exact; resize, mouse and close without hangs; regression tests on real ptys.

Lenguaje dominante
Rust
Estrellas
3
Forks
1
Merge medio
9 h 51 min
PR fusionados (30 d)
310

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de codeatlasdev/atlas

Todos los issues de codeatlasdev/atlas

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.