Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Extract project join status from project-card component into a separate component

Abierto
#1,181 0 comentarios 0 reacciones 1 asignado Ver en GitHub

@daveconnis ya está trabajando en esto.

Desde el 18/10/2017.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Difficulty: Easy Skill: ember-cli-page-object Skill: Ember.js Skill: JavaScript Skill: Testing

Problem

The logic for the project status/join button in the project card template is highly complex. We could simplify it by extracting a part.

The following code:

{{#if currentProjectMembership.isLoaded}}
  {{#if (eq currentProjectMembership.role 'pending')}}
    <button class="clear small" disabled>Request sent</button>
  {{else}}
    <button class="clear small" disabled>Member</button>
  {{/if}}
{{/if}}

{{#unless currentProjectMembership}}
  {{project-join-modal project=project skills=projectSkills}}
{{/unless}}

should be replaced with the equivalent of:

{{#if currentProjectMembership}}
  {{membership-status membership=currentProjectMembership}}
{{else}}
  {{project-join-modal project=project skills=projectSkills}}
{{/if}}

Subtasks

  • Implement component
  • Write integration tests for component
    • If current project membership is loading, it renders nothing
    • If current project membership is loaded and role is pending, it renders the "Request sent" button
    • If current project membership is loaded and role is something else, it renders the "Member" button
    • [ ] A page-object should be written for these tests
  • Replace code with component
  • Add integration tests for project card component
    • If there is a current project membership, it renders the project-membership-subcomponent
    • If there is no current project membership, it renders the project-join-modal subcomponent
    • The project-card page object will need to be expanded with two new properties for this
Lenguaje dominante
JavaScript
Estrellas
120
Forks
75
Sin PR fusionados en 30 d

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de code-corps/code-corps-ember

Todos los issues de code-corps/code-corps-ember

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.