Suggestions
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Documentación
- Claridad
- Necesita aclaración
- Estado de actividad
- Estancado
- Stack tecnológico
- go
- Área
- documentation
Línea de trabajo
Empieza revisando el README del repositorio y la sección vinculada sobre migración de errores en docs/RFCS/20190318_error_handling.md; después, inspecciona cómo se presentan actualmente exthttp y extgrpc. El issue contiene muchas sugerencias independientes, así que primero identifica un único cambio de documentación acordado. La tarea estará terminada cuando haya una actualización centrada, con ejemplos o enlaces que correspondan al alcance elegido.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
For @knz
I was looking through the docs trying to find out how to register a migrated error, and it took me a little bit. So I wanted to suggest how to make that more visible, and then I thought while I'm at it, a couple more suggestions:
- First, the docs on migrating/renaming an error are a little buried and could perhaps be linked in the README. You talk about forward compatibility in the README, which I understand in part to involve forwarding errors through unaware intermediaries but from the name it sounds like error migration is part of it, so I was surprised how much I had to dig to re-find this data.
-
RegisterTypeMigrationcould perhaps be part of the "forwarded methods" so it shows up in the main package, looks like I currently need to importerrbaseto get at it. - The README could use a sample of the ultra-awesome stack trace format!
- The compatibility table is a bit intense to be at the top of the README. I remember back when I first came across this package, it was a little confusing—my takeaway was, "wow, this thing has lots of features I guess". I feel like you might be better served by having the top of the README dedicated to a simple bullet-point list of features and some code samples showing what it looks like in practice.
- Could have a godoc badge up at the top of the README:
- Perhaps rethink how the data on custom errors is provided. The information is pretty dense and unstructured; I would suggest more subheadings for specific tasks like "Custom Leaf", "Custom Wrapper", "Over the Network", or some such. Also perhaps consider putting the writeup in its own document because there's a lot to the subject and it can be overwhelming to someone landing on the main page of the repo.
- This is subjective, but I think in general the README could express more through code samples:
- The section on Available Error Leaves could show little fake error scenarios, using that applicable function, and then retrieving the data, with additional details in comments.
- The section How to Use could perhaps be shown in code.
- I question the necessity of API (not constructing error objects), since Godoc is probably better suited for this anyway.
- I don't think the
exthttppackage is mentioned as a useful tool, more as an example for when you're building your own error types, but I think it adds value. Alsoextgrpcisn't mentioned, although that one's entirely my fault because I never added docs for the work I did 😉 - I feel like the project deserves a cool logo! (😄 ) Maybe a variation of the cockroachdb logo?
I'm aware that I'm armchair-quarterbacking and should probably put a PR where my mouth is, but I'm in the middle of other things and just felt compelled to jot down some notes. Interested to hear your thoughts!
- Lenguaje dominante
- Go
- Estrellas
- 2.5k
- Forks
- 75
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de cockroachdb/errors
-
Errors returned from Join are incompatible with errors returned the standard lib's errors.Join Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 52/100
cockroachdb/errors#162 · 1 comentario ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
cockroachdb/errors#156 · 20 reacciones ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 30/100
cockroachdb/errors#155 · 1 comentario · 1 reacción ·
-
move subpackages to internal Abierto
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
cockroachdb/errors#146 ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
cockroachdb/errors#145 · 1 comentario · 1 reacción ·
Todos los issues de cockroachdb/errors
Issues similares
-
textual definition
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
geneontology/go-ontology#32653 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 75/100
-
needs design
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Priority/High ready-for-agent Severity/Major Type/Bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100