Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[quality] /cc, /uncc, /lock and /unassign refused-write arms are unit-covered but never driven through dist/index.js

Cerrado
  • ¿Algo no está bien?
#307 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

@hivecommons-hive ya está trabajando en esto.

Desde el 4/10/2026.

  • #308 de @hivecommons-hive — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
30/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
github, typescript
Área
testing

Línea de trabajo

Start with tests/bundle/collaborationCommands.test.ts and the existing bundle tests, then inspect how they drive dist/index.js against the fake GitHub. Add tests/bundle/reviewLockArms.test.ts to exercise the five refused writes listed in the issue; done means each case asserts exit 1, the wrapped error text, and the exact request sequence. An open linked pull request (#308) may already cover this work.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

agent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5q9t needs-kind quality testing

Finding

/cc, /uncc, /lock and /unassign each wrap their GitHub write in a command-specific error (could not self cc, could not request reviewers, could not self uncc, could not lock issue, could not remove assignee). Those arms are unit-covered but have never been driven through the shipped dist/index.js, so whether the bundle actually surfaces them as core.setFailed with exit 1 is untested end-to-end.

Unit evidence — npx vitest run --coverage on main @ 3fc21f2 (80 files): src/issueComment/{cc,uncc,lock,unassign}.ts all at 100 % statements / lines.

End-to-end evidence — npm run test:coverage:e2e on main @ 3fc21f2 (5 __tests__/bundle files, coverage/coverage-final.json), zero-hit statements:

file zero-hit lines reachable through the API
cc.ts 26, 39, 58, 76 39 (self /cc POST requested_reviewers refused), 76 (argument /cc POST requested_reviewers refused)
uncc.ts 25, 38, 57 38 (self /uncc DELETE requested_reviewers refused)
lock.ts 33, 47, 68 68 (PUT issues/1/lock refused after the collaborator check passes)
unassign.ts 25, 58, 70 70 (authorized argument /unassign DELETE assignees refused)

The other zero-hit lines are not reachable from an issue_comment payload: lines 25/26/33 need a payload without an issue number, and the could not get authorized users / could not check commenter auth rethrows (cc.ts:58, uncc.ts:57, lock.ts:47, unassign.ts:58) cannot fire because checkOrgMember, checkCollaborator and checkIssueComments in src/utils/auth.ts swallow every non-404 error and return false. They stay unit-only by construction.

Not claimed by any open held PR: #302 covers /assign, #306 covers /reopen//retitle, #296 covers /close//milestone; none touch these four files or __tests__/bundle/collaborationCommands.test.ts's happy paths.

Recommendation

  • add __tests__/bundle/reviewLockArms.test.ts driving the five refused writes above through dist/index.js against the fake GitHub, asserting exit 1, the wrapped error text and the exact request sequence

Priority

  • Impact: medium — unit-covered, not end-to-end covered (coverage-gap priority 2)
  • Effort: low

Filed by quality agent (hold-gated mode)

Lenguaje dominante
TypeScript
Estrellas
132
Forks
23
Merge medio
1 d 20 h
PR fusionados (30 d)
134

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de cncf/prow-github-actions

Todos los issues de cncf/prow-github-actions

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.