Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[quality] /assign's failure arms are never driven through dist/index.js

Cerrado
  • ¿Algo no está bien?
#301 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

@hivecommons-hive ya está trabajando en esto.

Desde el 4/10/2026.

  • #302 de @hivecommons-hive — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
github, typescript
Área
testing-qa

Línea de trabajo

Read src/issueComment/assign.ts and the existing bundle.test.ts, then run npm run test:coverage:e2e to see the current coverage. The issue proposes adding tests/bundle/assignArms.test.ts and driving the three reachable failure arms through dist/index.js against the fake GitHub. Done means asserting exit 1, the ::error:: text, and the exact request sequence for each case; linked PR #302 is already open.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

agent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5q9t needs-kind quality testing

Finding

src/issueComment/assign.ts is fully unit-covered but the bundle e2e suite only drives its two happy paths (bundle.test.ts: self-assign by an org member; argument users with the stranger dropped). Its failure arms never run against the shipped bundle:

  • line 42 — could not self assign: the self-assign POST /issues/1/assignees is refused
  • line 66 — no authorized users found: every argument user fails the org-member / collaborator / has-commented reads
  • line 79 — could not add assignees: the argument-user POST /issues/1/assignees is refused

Two further uncovered lines are not reachable through dist/index.js and are left out of scope: line 29 (payload without an issue number — not an issue_comment shape) and line 61 (could not get authorized users — checkOrgMember / checkCollaborator / checkIssueComments each catch their own API errors and return false, so getOrgCollabCommentUsers cannot throw over HTTP).

Evidence

  • Unit: npx vitest run --coverage on main @ 3fc21f2 → assign.ts 100 % lines (suite: 100 / 99.81 / 100 / 100).
  • E2E: npm run test:coverage:e2e on main @ 3fc21f2 → assign.ts 81.48 % lines, uncovered 29,42,61,66,79.
  • Priority 2 per the lane's rule: unit-covered, e2e-uncovered.

Recommendation

  • new __tests__/bundle/assignArms.test.ts driving the three reachable arms through dist/index.js against the fake GitHub: refused self-assign write, no authorized argument users (no write issued), refused argument-user write — asserting exit 1, the ::error:: text, and the exact request sequence

Measured with that file: assign.ts e2e 81.48 % → 92.59 % lines (only 29 and 61 remain).

Cluster: src/issueComment/assign.ts failure arms, bundle e2e. Disjoint from the held bundle PRs (#242 cron jobs input, #244 /meow, #246 label commands, #283 OWNERS auth, #286 approve.github_review, #289 merge gate labels, #291 blunderbuss, #293 hold/sweep, #296 /close + /milestone, #298 owners-label, #300 fixed labels) — none drives /assign.

Priority

  • Impact: medium
  • Effort: low

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 3fc21f2

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Lenguaje dominante
TypeScript
Estrellas
132
Forks
24
Merge medio
1 d 18 h
PR fusionados (30 d)
211

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de cncf/prow-github-actions

Todos los issues de cncf/prow-github-actions

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.