Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[BUG] LNbits >= 1.0: ISO 8601 time/expiry parsed as unix seconds, paid admissions never confirmed

Abierto
  • ¿Algo no está bien?
#927 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
typescript
Área
backend, payments

Línea de trabajo

Start with LNbitsPaymentsProcessor.getInvoice() and trace how details.time and details.expiry become invoice dates. Check the processor’s unit tests for numeric and ISO 8601 responses; done means paid invoices confirm and expired invoices retire for both formats. The issue author says a fix and tests are ready and plans to open a pull request.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Describe the bug
With LNbits >= 1.0 as the payments processor, paid admissions are never confirmed and expired invoices stay pending forever.

LNbits 1.x returns details.time and details.expiry from GET /api/v1/payments/{payment_hash} as ISO 8601 strings (e.g. "2025-10-11T15:24:27+00:00"); LNbits 0.x returned unix seconds. LNbitsPaymentsProcessor still does new Date(data.details.time * 1000) / new Date(data.details.expiry * 1000), which yields Invalid Date for strings. As a result:

  • PaymentsService.confirmInvoice → InvoiceRepository.confirmInvoice calls confirmedAt.toISOString() → RangeError: Invalid time value, so a user who paid the admission invoice is not admitted (both from the /callbacks/lnbits webhook and from the maintenance worker poll);
  • isExpiredInvoice() is false for an invalid expiresAt, so unpaid invoices that LNbits still knows are re-saved as pending on every maintenance pass and never retired.

To Reproduce

  1. Run nostream with payments.enabled: true, payments.processor: lnbits against LNbits 1.x (seen with 1.5.6).
  2. Request an admission invoice at /invoices and pay it.
  3. The invoice is not confirmed and the pubkey is not admitted; unpaid invoices past their expiry remain pending in the invoices table.

Unit-level reproduction: feed invoiceResponse({ data: { paid: true }, details: { time: '2025-10-11T15:24:27+00:00' } }) to LNbitsPaymentsProcessor.getInvoice() — confirmedAt is Invalid Date.

Expected behavior
Dates from LNbits are parsed correctly whether they come as unix seconds (LNbits < 1.0) or ISO 8601 strings (LNbits >= 1.0); paid invoices get confirmed, expired ones get retired.

System

  • OS: Ubuntu 22.04
  • Platform: docker (compose)
  • Version: nostream 3.4.1 (same code in 2.1.0 and current main); LNbits 1.5.6

Logs
On 3.4.1 after the upgrade, 15 old unpaid invoices that LNbits still knows were re-saved as pending every minute; with the fix applied they were retired as expired on the next maintenance pass.

Additional context
I have a small fix with unit tests ready (accept both a number and an ISO string in the LNbits processor) and will open a PR referencing this issue.

Lenguaje dominante
TypeScript
Estrellas
829
Forks
234
Merge medio
16 h 13 min
PR fusionados (30 d)
74

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de cameri/nostream

Todos los issues de cameri/nostream

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.