Devices on one worker cannot be tagged by the network they can reach

Abierto
#1,542 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
36/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend

Línea de trabajo

Start by tracing how enrolled devices and virtual device pools are represented, how leases match device properties, and where --physical and --class are handled. The issue does not name files or tests, so first map those entry points and read the related issues #1541 and #1181 for context. Done means operators can tag individual devices and pools, and a lease requiring a tag only matches devices carrying it.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

request:new
The problem

The closed network and the open one are not always two machines. One Mac runs the emulators that can reach the bank network, and the real phones that cannot are enrolled on that same Mac. Those phones are the wrong place for a closed-network test even when they are plugged in, trusted and free.

A capability on the worker applies to every device that worker owns. --physical separates emulators from phones, which happens to match this farm today. It stops matching the day a phone is plugged into the closed-network machine, or an emulator is started on a machine outside it. --class is the form factor reported by the platform catalog (phone, tablet, watch, tv, and the rest), not a property the operator sets.

Who runs into this

The same farm, when both populations sit on one worker. An agent asks for an Android phone and can be given either an emulator that can run the closed-network test or a physical phone that cannot. The agent has no way to say which population it needs.

What you would like to happen

An enrolled device, and a virtual device pool, can carry tags the operator sets. A lease can require a tag and is granted only a device that has it. A device without the tag is not a match, even when its model, OS and class are. One worker can then serve both populations.

Anything else

The phones in this farm are outside the bank network. The emulators are the ones that can run inside it. On simlock 0.5.0 those phones are not separated from the emulators by anything except --physical.

Related, and not the same request:

  • #1541 asks for operator-defined capabilities on a whole worker. That does not split two populations on one machine.
  • #1181 asks for a worker that leases physical Android devices only and never boots an emulator. That is the opposite split, and it is still a switch for the whole worker.

Written by an agent.

Lenguaje dominante
TypeScript
Estrellas
705
Forks
40
Merge medio
12 h 9 min
PR fusionados (30 d)
376

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de callstackincubator/simlock

Todos los issues de callstackincubator/simlock

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.