composefs/grub: Type 1 entry order is arbitrary when os-release has no VERSION_ID/VERSION

Abierto Apto para principiantes
#2,669 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
76/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust

Línea de trabajo

Empieza en crates/lib/src/bootc_composefs/boot.rs en el fallback version_opt.unwrap_or_else(|| id.to_hex()) dentro de setup_composefs_bls_boot, luego lee type1_entry_conf_file_name y get_sorted_type1_boot_entries (b.filename.cmp(&a.filename)) para ver cómo el campo de versión acaba en el nombre de archivo. Sustituye el digest por una constante para la ordenación mientras mantienes el digest en el título, luego reproduce con dos BLSConfigs pasados a get_sorted_type1_boot_entries_helper(.., Bootloader::Grub) y ejecuta las pruebas de arranque de composefs. Hecho significa que la entrada de prioridad -1 se ordena primero independientemente del digest.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

When composefs uses GRUB with Type 1 entries, bootc orders the entries by file name, descending (get_sorted_type1_boot_entries, Bootloader::Grub → b.filename.cmp(&a.filename), see #2221). The file name is bootc_{os_id}-{version}-{priority}.conf (type1_entry_conf_file_name). version comes from VERSION_ID, then VERSION, in /usr/lib/os-release.

Some os-release files have neither key, for example Debian sid/testing and Arch Linux. For those, setup_composefs_bls_boot falls back to the deployment's verity digest:

// crates/lib/src/bootc_composefs/boot.rs (main @ 2a59b59, also v1.16.10)
version_opt.unwrap_or_else(|| id.to_hex()),

As a result, the version field is a random hex string that changes with every deployment, and it sorts before the priority field. After an upgrade:

loader/entries/bootc_debian-3f…(new digest)…-1.conf   # primary (new)
loader/entries/bootc_debian-c0…(old digest)…-0.conf   # secondary (booted)

The descending file-name order puts the old deployment first here, because c > 3. So bootc (and GRUB's blscfg, which uses the same name-version-release order) treats the old deployment as the default, and the upgrade is never booted. With other digests the new one wins. bootc rollback swaps only the priority field, so it is just as arbitrary.

With systemd-boot this does not happen, because the sort-key (bootc-{os_id}-{0,1}) comes first.

Reproducer
  1. bootc install to-disk --composefs-backend --bootloader grub an image whose /usr/lib/os-release has no VERSION_ID and no VERSION. A Debian sid based bootc image works, and so does the stock Arch os-release.
  2. bootc upgrade to a new image, then reboot so that bootc-finalize-staged runs.
  3. ls /sysroot/boot/loader/entries: the two entries differ only in the digest and the priority. The -1 (new) entry is first only when its digest sorts higher.

The logic needs no VM. Feed two BLSConfigs named as above to get_sorted_type1_boot_entries_helper(.., Bootloader::Grub), and the order follows the digests.

Possible fix

When os-release has no version, use a constant (for example 0) in place of the digest. Then the priority (release) field decides between the deployments of one OS, as it does when VERSION_ID stays the same across builds. The title/version shown to the user can keep the digest.

Context

We hit this while booting TunaOS flounder:gnome-sid (Debian sid, bootc 1.16.10, composefs) through a GRUB chain (tuna-os/wootc#768).

Lenguaje dominante
Rust
Estrellas
2.3k
Forks
230
Merge medio
2 d 11 h
PR fusionados (30 d)
42

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de bootc-dev/bootc

Todos los issues de bootc-dev/bootc

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.