Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Make transaction sending fully async so the UI only reports success after broadcast completes

Abierto
  • ¿Algo no está bien?
#360 0 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
swift
Área
mobile

Línea de trabajo

Comienza con BDKSwiftExampleWallet/Service/BDK Service/BDKService.swift y sigue el flujo de envío a través de BuildTransactionViewModel.swift y BuildTransactionView.swift. Actualiza el flujo para que la firma y la difusión se completen antes de informar del éxito, elimina la heurística de retardo fijo y verifica que los fallos permanezcan en la pantalla de envío, mientras que las difusiones exitosas muestren el éxito posteriormente.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

The current send flow can report success before the transaction has actually been broadcast.

BDKClient.send is exposed as a synchronous throwing API, but the live implementation immediately starts an internal Task and returns without waiting for the async broadcast to finish. Because of that, the UI continues as if the send succeeded even though the real network operation is still in progress.

Why This Matters

This creates a user-facing correctness bug:

  • The app can show a success state before the transaction is actually broadcast.
  • Broadcast failures may be surfaced too late, or not in the right screen context.
  • The user can be navigated away from the send screen even if the transaction was rejected.
  • A wallet app should never optimistically confirm a send before the backend confirms success.

Current Behavior

  • BuildTransactionViewModel.send() calls bdkClient.send(...).
  • The live BDKClient.send implementation starts a background Task and returns immediately.
  • BuildTransactionViewModel then posts TransactionSent right away.
  • BuildTransactionView waits one second and assumes success if no error has appeared yet.

This means success is based on timing, not on the actual result of the broadcast.

Expected Behavior

The send flow should only report success after signing and broadcasting have completed successfully.

Proposed Fix

  • Change the send API from synchronous to async throws across the stack.
  • Make BDKClient.send await BDKService.send(...) directly instead of wrapping it in a detached Task.
  • Update BuildTransactionViewModel.send() to be async.
  • In BuildTransactionView, await the send call and only show the success UI after it returns successfully.
  • Remove the one-second timer-based success heuristic.
  • Post wallet update notifications only after the async send has actually succeeded.

Suggested Acceptance Criteria

  • A failed broadcast does not show the success checkmark.
  • The user remains on the send screen when send fails.
  • A successful broadcast shows success only after the async operation completes.
  • No send-related state depends on fixed delays or race-prone background fire-and-forget tasks.

References

  • BDKSwiftExampleWallet/Service/BDK Service/BDKService.swift
  • BDKSwiftExampleWallet/View Model/Send/BuildTransactionViewModel.swift
  • BDKSwiftExampleWallet/View/Send/BuildTransactionView.swift
Lenguaje dominante
Swift
Estrellas
31
Forks
16
Merge medio
1 d 22 h
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de bitcoindevkit/BDKSwiftExampleWallet

Todos los issues de bitcoindevkit/BDKSwiftExampleWallet

Issues similares

Más issues de Swift

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.