Startup worktree sweep warns about the worktrees of attempts it is reattaching

Abierto
  • ¿Algo no está bien?
#1,044 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
73/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend, testing

Línea de trabajo

Start with packages/executor/src/remote/sweep.ts and trace how abandonedWorktreeSweepFor identifies attempts and logs paths. Find the durable harness data for open attempts and the existing sweep tests, then add a test with a reattached attempt worktree beside a genuinely abandoned path. Done means known attempts are excluded from the warning, while abandoned paths are summarized at WARN and listed at debug.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

abandonedWorktreeSweepFor in packages/executor/src/remote/sweep.ts lists every direct child of the worker's attempts/ directory and logs each one at WARN as "Preserving abandoned remote path for salvage reconciliation". The sweep runs once per worker at the first prepare after a restart, which is when the attempts that survived the restart are being reattached. Their own worktrees are therefore reported as abandoned.

Seen on 2026-11-07 at 12:17:17Z after the upgrade to 0.5.1-next.443: attempt 932b2964a857cc2d9183a0905b134d51/review/1 (#1043 review) was reattached at 12:17:15 ("Attempt reattached after an orchestrator restart"), and two seconds later the sweep it triggered warned about its own worktree .../attempts/932b2964a857cc2d9183a0905b134d51_review_1. Nothing was removed, so there is no functional harm, but the WARN is wrong and it is the only WARN of an otherwise clean restart, so it is what an operator reads first.

Fix: exclude the worktrees of attempts the durable harness still knows (at least the attempt that triggered the sweep, better every open attempt on that worker) from the warning, and log the rest at WARN with a count plus the paths at debug. Add a test with a reattached attempt whose worktree exists next to one genuinely abandoned path.

Related ordering oddity from the same restart, same place to fix if it is the same code path: at the forced stop (12:15:06), "Interrupting the child of an aborted tool call" and "Interrupting Claude child session" were logged after "Attempt settled during drain" and after the container was already removed, so the interrupt had nothing to act on.

Lenguaje dominante
TypeScript
Estrellas
1
Forks
0
Merge medio
3 h 23 min
PR fusionados (30 d)
400

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de basaltbytes/usine

Todos los issues de basaltbytes/usine

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.