Inbox: allow embedding the Inbox window in a trusted host (configurable frame-ancestors)

Abierto
  • ¿Algo no está bien?
#3,299 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
electron, typescript
Área
backend, security

Línea de trabajo

Start with the Inbox server's response headers, where X-Frame-Options: DENY and frame-ancestors 'none' are set, and with the existing buildFrameAncestorsPolicy in the preview proxy as the pattern to follow. Add an opt-in value from PLANNOTATOR_INBOX_FRAME_ANCESTORS or --frame-ancestors, leaving the default unchanged. Done means that with the setting unset the headers are identical to today, and with it set frame-ancestors is sent and X-Frame-Options is dropped, while the same-origin write checks still pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

The Inbox server answers every page with X-Frame-Options: DENY and frame-ancestors 'none'. That is the right default, but it blocks a legit setup: showing the Inbox (and the Board, #board) inside a local agent desktop app, next to the chat that writes to it. Today the only way is a local reverse proxy that strips those headers and rewrites Origin/Host so the Inbox's same-origin check still passes. It works, but every user who wants this has to rebuild the Inbox's CSRF and DNS-rebinding checks in the proxy, which is easy to get wrong.

Plannotator already does this for editors: the preview proxy sets frame-ancestors <editor origins> (buildFrameAncestorsPolicy). The Inbox has no equivalent.

Proposal

An opt-in setting, for example PLANNOTATOR_INBOX_FRAME_ANCESTORS (env) or plannotator inbox --frame-ancestors "<origins>":

  • when unset, nothing changes (DENY / 'none');
  • when set, the Inbox sends frame-ancestors <value> and drops X-Frame-Options, and nothing else changes: the cross-origin check on writes stays as it is, because the framed page is still same-origin with the server.

Use case

Hermes desktop (Electron) plugin: an "Inbox" and a "Board" page that load http://plannotator.localhost:61738/#board in an iframe, so the person answers threads and moves cards without leaving the agent app. The UI stays the Inbox's own bundle, so it keeps up with plannotator update.

Happy to send a PR if the shape looks right.

Lenguaje dominante
TypeScript
Estrellas
8.7k
Forks
649
Merge medio
10 h 45 min
PR fusionados (30 d)
830

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de backnotprop/plannotator

Todos los issues de backnotprop/plannotator

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.