Add a first-class teardown command that reports what it retained
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- aws, typescript
- Área
- cli, cloud, infrastructure
Línea de trabajo
Empieza siguiendo la ruta de teardown existente de agentcore deploy --yes y los puntos de entrada agentcore deploy --help y agentcore help modes. Compara su comportamiento con agentcore remove agent --name <runtime> --yes, el diff de CDK y los recursos de AWS observados. Se considera terminado cuando exista un comando de teardown documentado y confirmado que funcione sin secrets e informe de todos los recursos retenidos o que se puedan eliminar manualmente, incluidos los proveedores de credenciales y los grupos de logs.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Description
There is no agentcore destroy, or any teardown or decommission command. agentcore remove only edits local agentcore.json, and agentcore stop covers A/B tests and batch evaluations.
The only way to tear a project down through the CLI is undocumented: empty every resource array in agentcore.json, then run agentcore deploy --yes, which triggers a full cdk destroy. That works, and the output does show a Tear down stack step, but it has four problems:
- It is undiscoverable. It appears in neither
agentcore deploy --helpnoragentcore help modes. We only found it by reading the CLI source. - It is spelled as a deploy.
agentcore deployto destroy everything reads as the opposite of what it does, which is an uncomfortable command to hand to an operator whose intent is deletion. - It requires the project's secrets present just to tear down. With no
agentcore/.env.local, the deploy fails asking forAGENTCORE_CREDENTIAL_<NAME>. So a fresh clone, or a new machine, cannot retire a project until the operator recreates the very secrets they intend to destroy. We hit this on a real retirement where the credential no longer mattered. - It silently leaves resources behind. Lambda log groups carry
DeletionPolicy: Retain, so a teardown orphans one per Container runtime.cdk diffshows this correctly asorphan, but the CLI's own output never mentions that anything was retained. Repeated create-and-retire cycles accumulate orphans indefinitely.
Retaining logs may well be intentional, and there is a reasonable case for it. The gap is that it is invisible: the information exists inside the CLI's own diff and never reaches the operator.
Combined with the missing credential-provider deletion in #2022, a "successful" teardown today can leave an orphaned credential provider, its backing secret, and one log group per runtime, with nothing reporting any of it.
Acceptance Criteria
- A documented teardown command exists, for example
agentcore destroy --target <target>, discoverable from--help. - It deletes the project's CloudFormation stack.
- It deletes each API-key credential provider the project owns, or clearly reports each one the operator must delete manually, with the exact command.
- It reports every resource the stack retained rather than deleted, naming each one, so the operator knows what remains in the account.
- It does not require credential secrets to be present in order to tear down, since the secrets are being destroyed.
- It requires explicit confirmation before deleting, consistent with the existing
--yesgate on the current teardown path. - Tearing down a project and then listing account resources leaves no untracked leftovers attributable to that project, or every leftover was named in the command's output.
Additional Context
Verified on @aws/agentcore 0.27.0 (macOS, Node v22.22.1, aws-cdk 2.1126.0, managedBy: CDK, Container builds) using a throwaway two-runtime project created specifically to test teardown behavior.
What we observed after a teardown that reported success:
aws cloudformation describe-stacks --stack-name AgentCore-RetireTest-<target> --region us-east-1
# Stack does not exist. Correct.
aws logs describe-log-groups --log-group-name-prefix "/aws/lambda/AgentCore-RetireTest" --region us-east-1
# 2 log groups still present, one per runtime:
# /aws/lambda/AgentCore-RetireTest-jobb-ApplicationAgentAlphaAmp-...
# /aws/lambda/AgentCore-RetireTest-jobb-ApplicationAgentBetaAmpC-...
aws bedrock-agentcore-control list-api-key-credential-providers --region us-east-1
# the project's provider still present (#2022)
The teardown output that preceded it gave no indication anything survived:
✓ Deploy to AWS
✓ Tear down stack
✓ Deployed to '<target>' (stack: AgentCore-RetireTest-<target>)
Worth noting that single-runtime retirement already works well, and could serve as the model. agentcore remove agent --name <runtime> --yes followed by agentcore deploy correctly scoped the CDK diff to just that runtime, spared the sibling runtime entirely, and narrowed the shared container-build IAM policy rather than deleting it. The only gap there is the same retained log group. So the mechanism is sound; what's missing is a command named for the intent, plus reporting of what it left behind.
Because of the gaps we ended up writing an internal wrapper that deletes the stack, then each credential provider, then each retained log group, and verifies all three. A documented agentcore destroy would let us delete that wrapper.
- Lenguaje dominante
- TypeScript
- Estrellas
- 291
- Forks
- 96
- Merge medio
- 21 h 31 min
- PR fusionados (30 d)
- 217
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de aws/agentcore-cli
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
aws/agentcore-cli#2395 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
aws/agentcore-cli#2392 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
aws/agentcore-cli#2267 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
aws/agentcore-cli#2258 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
aws/agentcore-cli#2176 ·
Todos los issues de aws/agentcore-cli
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
bcgov/bc-wallet-mobile#4761 · 1 comentario ·
-
external-issue to-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
-
area-deployment area-integrations triage:bot-seen
Dificultad 2/5 Medio día Aptitud para principiantes 86/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
-
refactor
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100