bug: @ts-ignore causing issues when libchecking providers

Abierto

#132 abierto el 10/3/2025 0 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad: 4/5
Tiempo estimado: 3-5 días
Aptitud para principiantes: 32/100

Tipo de issue: Error
Claridad: Necesita aclaración
Estado de actividad: Estancado
Stack tecnológico: node.js, typescript
Área: build-system, tooling

Línea de trabajo

Comienza con src/interface.ts, especialmente con las líneas 69-82, y compáralo con el archivo generado node_modules/@amazon-web-services-cloudformation/cloudformation-cli-typescript-lib/dist/interface.d.ts. Reproduce el fallo de lib-check/build de TypeScript informado y rastrea por qué se añadieron las declaraciones Integer e IntegerConstructor. La tarea está terminada cuando el provider puede ejecutar lib-check sin los errores TS2430 informados.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

i am unable to do libChecking on my providers as this commit adds @ts-ignore directives to the interface Integer here.

for this is problematic as it causes the following issue when building my resources (below).
i think the suggestion in the commit message is that resources should disable "lib checking". I dont see this as a great solution as it applies to all libraries. As i use aws-sdkv3 in my resources (and additional components i build using smithy), i have more than once caught issues due to incompatibilities between transient dependencies.

reviewing the code i am also not able to understand why the code was added to the interface. browsing through the issues and commit messages doesn't seem to provide answers to this question either.

any recommended path forward is greatly appreciated.
@kddejong, @ericzbeard

node_modules/@amazon-web-services-cloudformation/cloudformation-cli-typescript-lib/dist/interface.d.ts:30:11 - error TS2430: Interface 'Integer' incorrectly extends interface 'BigInt'.
  Types of property '[Symbol.toStringTag]' are incompatible.
    Type '"Integer"' is not assignable to type '"BigInt"'.

30 interface Integer extends BigInt {
             ~~~~~~~

node_modules/@amazon-web-services-cloudformation/cloudformation-cli-typescript-lib/dist/interface.d.ts:35:11 - error TS2430: Interface 'IntegerConstructor' incorrectly extends interface 'BigIntConstructor'.
  Types of property 'prototype' are incompatible.
    Type 'Integer' is not assignable to type 'BigInt'.

35 interface IntegerConstructor extends BigIntConstructor {

Lenguaje dominante: TypeScript
Estrellas: 46
Forks: 18
Métricas de merge de PR: Sin PR fusionados en 30 d