getCredentials fails on an unrecognized fingerprint while the biometric prompt is still open
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Aptitud para principiantes
- 72/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Área
- authentication, mobile
Línea de trabajo
Empieza en auth0/src/main/java/com/auth0/android/authentication/storage/LocalAuthenticationManager.kt en onAuthenticationFailed(), que actualmente llama a resultCallback.onFailure(BIOMETRICS_INVALID_USER). Compáralo con onAuthenticationSucceeded() y onAuthenticationError(), que entregan el resultado final. Busca pruebas unitarias existentes para este gestor y ejecútalas. Se considera terminado cuando un fallo no final no informa nada y el callback recibe exactamente un resultado cuando se cierra el diálogo.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Checklist
- The issue can be reproduced in the Auth0.Android sample app (or N/A).
- I have looked into the Readme, Examples, and FAQ and have not found a suitable solution or answer.
- I have looked into the API documentation and have not found a suitable solution or answer.
- I have searched the issues and have not found a suitable solution or answer.
- I have searched the Auth0 Community forums and have not found a suitable solution or answer.
- I agree to the terms within the Auth0 Code of Conduct.
Description
SecureCredentialsManager.getCredentials() with local authentication fails as soon as one fingerprint is not recognized, while the biometric prompt is still open.
LocalAuthenticationManager.onAuthenticationFailed() calls resultCallback.onFailure(CredentialsManagerException.BIOMETRICS_INVALID_USER):
BiometricPrompt calls onAuthenticationFailed() when a biometric is read but not recognized. It is not a final result. The prompt stays open, so the user can try again or use the device credential fallback. The final result always comes later through onAuthenticationSucceeded() or onAuthenticationError().
Because of this the callback gets onFailure(BIOMETRICS_INVALID_USER) first and then, when the user does unlock, onSuccess. SecureCredentialsManager also calls updateBiometricSession() on that later success. So the session starts, but a caller that settles on the first result never sees it. That is what happens in react-native-auth0, where the first result rejects the JS promise and the later success is dropped.
Expected: onAuthenticationFailed() does not report anything, and the callback gets one result once the prompt closes.
The same applies to getApiCredentials(), which uses the same LocalAuthenticationManager.
Reproduction
- Configure
SecureCredentialsManagerwithLocalAuthenticationOptions,deviceCredentialFallback = trueandBiometricPolicy.Session. - Call
getCredentials(). - In the prompt, use a fingerprint that is not enrolled. With the emulator, touch the sensor with a finger that was not registered.
- The callback gets
onFailure(BIOMETRICS_INVALID_USER)right away, while the prompt shows "Not recognized" and stays open. - Tap "Use PIN" and enter the correct PIN.
- The callback now also gets
onSuccess, and the biometric session is valid. The nextgetCredentials()call returns credentials without a prompt.
This happens every time on a Pixel emulator.
Additional context
Found through react-native-auth0 5.11.0, which uses Auth0.Android 3.21.0. The app shows its locked state behind the prompt that is still open, ignores the PIN the user enters, and then unlocks without a prompt on the next attempt.
The same code is in 3.21.1, 4.1.0 and 5.0.0-beta.0.
A possible fix is to remove the resultCallback.onFailure call from onAuthenticationFailed(), or to only call super.
Auth0.Android version
3.21.0 (also present in 3.21.1, 4.1.0 and 5.0.0-beta.0)
Android version(s)
Pixel emulator. The behavior follows from how BiometricPrompt reports results, so it is not specific to one Android version.
- Lenguaje dominante
- Kotlin
- Estrellas
- 301
- Forks
- 183
- Merge medio
- 1 d 4 h
- PR fusionados (30 d)
- 14
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de auth0/Auth0.Android
-
Dificultad 4/5 3-5 días Aptitud para principiantes 28/100
auth0/Auth0.Android#1093 · 5 comentarios ·
Los mantenedores suelen responder en 1 día
Todos los issues de auth0/Auth0.Android
Issues similares
-
enhancement good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
xybrid-ai/xybrid#661 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
android bug kotlin vulkan
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
maplibre/maplibre-native-ffi#852 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 86/100
Los mantenedores suelen responder en 1 día
-
documentation importer size:S
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
enorm-labs/event-junkie#3614 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
InsertKoinIO/koin#2477 ·