Editor exception thrown from filesystem provider if source file doesn't exist
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 42/100
Línea de trabajo
Start with FilesCompletionProvider.GetEntries in the VSIX stack trace, then inspect FileSystemCatalog.GetLibraryAsync for the missing-source case. Reproduce with the provided libman.json and edit in Visual Studio. Done means editing no longer throws an editor exception, while restore still reports an appropriate error.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Functional impact
When editing libman.json in Visual Studio, if there is a library entry using the filesystem provider, and the file doesn't exist, it will throw an exception in the editor.
Minimal repro steps
- Have a project with the following libman.json:
{
"version": "1.0",
"defaultProvider": "filesystem",
"libraries": [
{
"provider": "filesystem",
"library": "node_modules/jquery/dist/",
"destination": "wwwroot/lib/",
"files": [
"jquery.min.js"
]
}
]
}
- Make sure the source files (in the node_modules folder) do not exist
- Make an edit in the editor
Expected result
Edits can happen fine, a restore will fail with an appropriate error
Actual result
As soon as I make an edit (e.g. type any character), I get an error from VS and an entry in the ActivityLog:
System.AggregateException: One or more errors occurred. ---> Microsoft.Web.LibraryManager.Contracts.InvalidLibraryException: The "node_modules/jquery/dist/" library could not be resolved by the "filesystem" provider at Microsoft.Web.LibraryManager.Providers.FileSystem.FileSystemCatalog.d__4.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject) --- End of inner exception stack trace --- at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions) at System.Threading.Tasks.Task
1.GetResultCore(Boolean waitCompletionNotification) at System.Threading.Tasks.Task1.get_Result() at Microsoft.Web.LibraryManager.Vsix.FilesCompletionProvider.d__2.MoveNext() at System.Collections.Generic.List1.InsertRange(Int32 index, IEnumerable1 collection) at Microsoft.JSON.Editor.Completion.JSONCompletionSource.<>c__DisplayClass3_2.b__0() at Microsoft.Web.Editor.Utility.GuardedOperations.InvokeExtensionPoint(Object errorSource, Action action) ---> (Inner Exception #0) Microsoft.Web.LibraryManager.Contracts.InvalidLibraryException: The "node_modules/jquery/dist/" library could not be resolved by the "filesystem" provider at Microsoft.Web.LibraryManager.Providers.FileSystem.FileSystemCatalog.d__4.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)<---
--
- Lenguaje dominante
- C#
- Estrellas
- 486
- Forks
- 91
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de aspnet/LibraryManager
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
aspnet/LibraryManager#824 · 1 comentario · 3 reacciones ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 68/100
aspnet/LibraryManager#804 · 2 reacciones ·
-
Changelog for 3.0.114 Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 48/100
aspnet/LibraryManager#829 · 1 comentario · 3 reacciones ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 42/100
aspnet/LibraryManager#820 ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
aspnet/LibraryManager#808 · 5 comentarios ·
Todos los issues de aspnet/LibraryManager
Issues similares
-
CS0162 "Unreachable code detected" warning from a MSBuildTemp .tmp file in every game project Abiertobug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
-
Type: enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
apache/arrow-adbc#4809 ·
-
type/automation type/tech-debt
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
microsoft/vscode-azurefunctions#5197 · 1 comentario ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
microsoft/microsoft-ui-reactor#1274 ·