Apple.Core appends a second CODE_SIGN_ENTITLEMENTS value instead of reusing the existing entitlements file

Abierto
#131 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
65/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp
Área
build-system

Línea de trabajo

Start in AppleBuild.OnPostProcessBuild and trace how the project reads and writes CODE_SIGN_ENTITLEMENTS for iOS, tvOS, and visionOS. Reproduce with the notification package setup described in the issue, then check that Apple.Core uses one entitlements file per target and that Xcode builds successfully.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug Plugin-in - Core

Describe the bug
On iOS and tvOS builds, AppleBuild.OnPostProcessBuild always writes its entitlements to <Product Name>.entitlements and adds that name to CODE_SIGN_ENTITLEMENTS with PBXProject.AddBuildProperty. It never checks what CODE_SIGN_ENTITLEMENTS already points to.

Unity's notification packages (com.unity.services.push-notifications, com.unity.mobile.notifications) run before Apple.Core's [PostProcessBuild(10)]. They read CODE_SIGN_ENTITLEMENTS first and, when it's empty, name the file after the last part of the bundle identifier. So whenever Product Name differs from that part, the project gets two entitlements files and CODE_SIGN_ENTITLEMENTS holds both names. Xcode then fails with an error naming a single file made of both names, for example ExampleGame.entitlements Example Game.entitlements.

The same happens without those packages when building into an existing Xcode project (Append) after changing Product Name: the old name stays and the new one is added next to it.

To Reproduce

  1. iOS project with Apple.Core and com.unity.services.push-notifications (or com.unity.mobile.notifications with push enabled).
  2. Product Name "Example Game", bundle identifier com.example.ExampleGame.
  3. Build for iOS into an empty folder, then build the generated Xcode project.

Expected behavior
One entitlements file per target. If CODE_SIGN_ENTITLEMENTS is already set, Apple.Core should merge its keys into that file, create a file only when none is set, and use SetBuildProperty so the setting never holds two values.

Environment
Unity 6000.6, iOS (tvOS and visionOS go through the same code). Seen with Apple.Core 3.2.0; the code is unchanged in 3.3.0 (27.0, ffe6174) and on main (96e4a04).

Additional context
Sketch of the fix in OnPostProcessBuild:

var targetGuid = pbxProject.GetUnityMainTargetGuid();
var entitlementsFileName = pbxProject.GetBuildPropertyForAnyConfig(targetGuid, "CODE_SIGN_ENTITLEMENTS");
if (string.IsNullOrEmpty(entitlementsFileName))
{
    var bundleIdentifier = PlayerSettings.GetApplicationIdentifier(NamedBuildTarget.FromBuildTargetGroup(BuildPipeline.GetBuildTargetGroup(buildTarget)));
    entitlementsFileName = $"{bundleIdentifier.Substring(bundleIdentifier.LastIndexOf('.') + 1)}.entitlements";
}
// read, merge and write {generatedProjectPath}/{entitlementsFileName}, then:
pbxProject.SetBuildProperty(targetGuid, "CODE_SIGN_ENTITLEMENTS", entitlementsFileName);

Related: #37 switches the file lookup to GetEntitlementFilePathForTarget but keeps AddBuildProperty with the Product Name path, so the setting still gets a second value. Our embedded copy uses the bundle-identifier name plus SetBuildProperty for iOS, tvOS and visionOS, which fixes it for us.

Lenguaje dominante
C#
Estrellas
1k
Forks
257
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apple/unityplugins

Todos los issues de apple/unityplugins

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.