Image-to-image parsing passes unvalidated url values to _url_to_data_url

Abierto
#8,886 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@PG1204 ya está trabajando en esto.

Desde el 6/10/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

What happened?

ImageTaskCodegen.parsePython's image-to-image branch hands provider-supplied values to _url_to_data_url without checking their type, and indexes images without checking it is a list. Verified by running the generated parser:

Response body Result
{"images": [{"url": null}]} _url_to_data_url called with None
{"images": [{"url": 7}]} _url_to_data_url called with an int
{"images": {"a": 1}} raises KeyError
{"data": [{"url": null}]} _url_to_data_url called with None

Three gaps:

  1. images[0]["url"] is unvalidated (lines 137-138). A non-string reaches _fetch_remote_url and urlparse.
  2. images is indexed without an isinstance(images, list) check (line 137). A dict body raises KeyError, which _parse_response catches, so it degrades by exception rather than cleanly.
  3. data[0]["url"] is unvalidated (lines 148-149), the same gap as 1.

The inconsistency is the clearest sign this is unintended: the output branch at line 133 and the outputs branch below it both already guard with isinstance(url, str) and url.startswith("http"). The images and data branches in the same function do not.

These do not abort the run and _parse_response catches KeyError, IndexError and TypeError, and the row loop catches the rest per row, so the effect is a wasted fetch attempt or a cell holding the raw body instead of an image.

This is the remainder of the same defect class as #8869 and #8870. #8885 was deliberately scoped to b64_json only, leaving these for a separate change.

How to reproduce?

Run the operator with image-to-image against a provider that returns a 200 whose images[0].url or data[0].url is null or numeric, or whose images is an object rather than an array.

Version/Branch

1.4.0-incubating-SNAPSHOT (main)

Commit Hash (Optional)

No response

What browsers are you seeing the problem on?

No response

Relevant log output

Lenguaje dominante
Scala
Estrellas
333
Forks
202
Merge medio
3 d 11 h
PR fusionados (30 d)
185

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/texera

Todos los issues de apache/texera

Issues similares

Más issues de Scala

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.