Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[BanyanDB] Stream write callback reports success for events it did not store

Abierto
  • ¿Algo no está bien?
#14,158 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@AnKiT-GaRG2 ya está trabajando en esto.

Desde el 26/10/2026.

  • #1443 de @AnKiT-GaRG2 — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
go
Área
backend, observability

Línea de trabajo

Start with banyand/stream/write_standalone.go, then read the error forwarding paths in banyand/queue/local.go and banyand/queue/sub/helpers.go and how batch statuses are applied in banyand/liaison/grpc/stream.go. Check the corresponding callbacks in banyand/measure and banyand/trace. Done means failures before any event is stored reach the caller, while partial and index-write failures do not cause stored events to be retried as failures.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

writeCallback.Rev (banyand/stream/write_standalone.go) logs each failed event and continues, and always returns an empty response. The caller gets STATUS_SUCCEED for elements that were not stored.

For example, for a missing group, handle fails in prepareElementsInGroup (cannot load tsdb for group). Rev logs cannot handle write event and returns no error.

Observed

With native self-stored logs (apache/skywalking-banyandb#1419) on a standalone node, a forced delete of _monitoring_log lost 3 events. native_log_written_total rose for them, and every native_log_dropped_total reason stayed 0.

Notes for a fix

  • The error reply path already exists: localBatchPublisher.Close (banyand/queue/local.go) and the data-node sub server (banyand/queue/sub/helpers.go) forward a *common.Error, as CheckHealth does for disk-full.
  • The liaison applies one status to every message it sent to a node in a batch (banyand/liaison/grpc/stream.go). Reporting an error on a partial failure would mark stored elements as failed, and a retrying client would store them twice. Report an error only when nothing in the batch was stored, or report per element.
  • Index-write failures happen after the elements are stored, so they should stay logged only.
  • banyand/measure and banyand/trace use the same pattern.

Effect on #1419

#1419 does not change this callback. Until it is fixed, events lost while the log destination is missing are counted as written, so a test cannot observe that loss.

Lenguaje dominante
Java
Estrellas
25k
Forks
6.6k
Merge medio
16 h 55 min
PR fusionados (30 d)
31

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/skywalking

Todos los issues de apache/skywalking

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.