[Bug] PopLiteMessageProcessor preCheck drops the consumer identity from the parentTopic-not-exist error log

Abierto
  • ¿Algo no está bien?
#11,435 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@messere1 ya está trabajando en esto.

Desde el 14/10/2026.

  • #11436 de @messere1 — abierto

Evaluación

Dificultad
1/5
Tiempo estimado
Menos de una hora
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
java
Área
backend

Línea de trabajo

The bug is in the preCheck method of PopLiteMessageProcessor, in the branch that logs 'The parentTopic {} not exist, consumer: {}' when selectTopicConfig returns null. The log call passes only the topic, so the consumer group from requestHeader.getConsumerGroup() needs to be added as the second argument. A test in PopLiteMessageProcessorTest should capture the log event and confirm the group name appears. A pull request (#11436) is already open against this issue, so check it before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Any.

RocketMQ version

develop branch (dc70260b7)

JDK Version

Any.

Describe the Bug

PopLiteMessageProcessor#preCheck reserves a log slot for the consumer when the parent topic of a lite pop request does not exist, but never passes the argument:

TopicConfig topicConfig = brokerController.getTopicConfigManager().selectTopicConfig(requestHeader.getTopic());
if (null == topicConfig) {
    LOGGER.error("The parentTopic {} not exist, consumer: {} ", requestHeader.getTopic());
    response.setCode(ResponseCode.TOPIC_NOT_EXIST);
    ...
}

The message template has two {} placeholders but only one argument. With SLF4J semantics the second placeholder is rendered literally, so the log line is:

The parentTopic xxx not exist, consumer: {}

The consumer group (available in PopLiteMessageRequestHeader#getConsumerGroup()) never appears. When a parent topic is deleted or a client is misconfigured, this ERROR is the only server-side trace of affected consumers — without the group, operators cannot tell who is impacted.

Steps to Reproduce

Unit-level, deterministic (PopLiteMessageProcessorTest harness):

  1. Build a PopLiteMessageRequestHeader with a topic that TopicConfigManager#selectTopicConfig returns null for and consumerGroup = "groupA".
  2. Call popLiteMessageProcessor.preCheck(ctx, requestHeader, response); it returns TOPIC_NOT_EXIST.
  3. Capture the formatted log event for logger RocketmqPopLite: the message is The parentTopic xxx not exist, consumer: {} — groupA is absent.
What Did You Expect to See?

The parentTopic xxx not exist, consumer: groupA

What Did You See Instead?

The parentTopic xxx not exist, consumer: {}

Additional Context

Only this line in the lite pop path has a placeholder/argument mismatch (verified by scanning all LOGGER/POP_LOGGER calls in PopLiteMessageProcessor, LiteEventDispatcher, LiteSubscriptionRegistryImpl, PopLiteLongPollingService and NotificationProcessor for the lite area). The sibling processor NotificationProcessor logs the remote address in the equivalent branch, so the pattern of identifying the caller is established — here the consumer group from the request header is the natural identifier.

Lenguaje dominante
Java
Estrellas
22.7k
Forks
12k
Merge medio
3 d 18 h
PR fusionados (30 d)
17

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/rocketmq

Todos los issues de apache/rocketmq

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.