validation: field reference resolution is case-insensitive but name uniqueness is case-sensitive

Abierto
#721 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@MikeNitsenko ya está trabajando en esto.

Desde el 12/11/2026.

  • #722 de @MikeNitsenko — abierto

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Necesita aclaración
Estado de actividad
Estancado
Stack tecnológico
python, yaml
Área
backend, data

Línea de trabajo

Read validation/validate.py, especially dataset_field_names() and validate_unique_names(), then compare their behavior with the Name Resolution section in spec.md and identifier rules in expression_language.md. Decide whether declared field names should be unique case-insensitively or references should resolve by exact case, and align the specification and validator. Check the open pull request #722 before starting; done means the chosen rule is documented and consistently validated.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

needs-triage

Problem

validation/validate.py resolves dataset field references case-insensitively,
but checks name uniqueness case-sensitively, so a dataset can declare two
fields that differ only by case and produce ambiguous references.

  • dataset_field_names() case-folds declared field names (name.casefold()),
    so primary_key, unique_keys, and relationship from_columns /
    to_columns match fields ignoring case.
  • validate_unique_names() runs find_duplicates() on the raw name
    strings, so id and ID are treated as distinct fields.

A dataset declaring fields id and ID therefore passes uniqueness
validation, yet primary_key: [id] (or [ID]) resolves into a case-folded
set where both collapse to the same entry — the reference cannot tell which
field was meant.

Question

Should the spec/validator make field-name uniqueness case-insensitive (reject
id + ID as duplicates), or should reference resolution be exact-case?
spec.md's Name Resolution section doesn't state the case rules for declared
names; expression_language.md says regular identifiers are case-insensitive,
but it's unclear whether that applies to YAML-declared field names used as
key/join references.

We hit this while aligning a downstream validator with the #486 name-resolution
rules: we mirror the upstream behavior (case-insensitive resolution,
case-sensitive uniqueness) and would rather fix the ambiguity upstream than
diverge from the reference validator.

Lenguaje dominante
Python
Estrellas
2.7k
Forks
353
Merge medio
3 d 19 h
PR fusionados (30 d)
86

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/ossie

Todos los issues de apache/ossie

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.