arch/ceva: cannot be selected, has no board, and tests the removed CONFIG_DISABLE_SIGNALS

Abierto
  • ¿Algo no está bien?
#21,075 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
c
Área
embedded-iot

Línea de trabajo

Start by checking arch/Kconfig, arch/ceva/Kconfig, and the listed signal guards in arch/ceva; compare them with other architectures’ CONFIG_ENABLE_ALL_SIGNALS guards. The issue offers two possible resolutions: make the port selectable and buildable by adding a board, or remove it. First determine whether the port is still in use; done means the selected path is resolved, including the stale signal configuration references if the port remains.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Description

arch/ceva (added in ee916bdb91c, 2022-01) cannot be built in the tree:

  • arch/Kconfig has no ARCH_CEVA option and does not source arch/ceva/Kconfig (which starts with if ARCH_CEVA). So no configuration can select the architecture.
  • No board under boards/ uses it, and no CI test list builds it.

The code is also out of date. 13 lines in 9 files test CONFIG_DISABLE_SIGNALS, which NuttX removed in 7.30 ("Signals can no longer be disabled"):

  • arch/ceva/include/xc5/irq.h:131, arch/ceva/include/xm6/irq.h:134
  • arch/ceva/src/common/ceva_schedulesigaction.c:38, :149
  • arch/ceva/src/common/ceva_sigdeliver.c:37, :98
  • arch/ceva/src/common/ceva_signal_dispatch.c:33
  • arch/ceva/src/common/ceva_svcall.c:281, :322
  • arch/ceva/src/common/ceva_userspace.c:217
  • arch/ceva/src/xc5/xc5_signal_handler.S:32, arch/ceva/src/xm6/xm6_signal_handler.S:32

The other architectures guard the same code with CONFIG_ENABLE_ALL_SIGNALS (0ea686bc5b3, partial signal support). With CONFIG_ENABLE_PARTIAL_SIGNALS or CONFIG_DISABLE_ALL_SIGNALS, ceva_userspace.c:218 and ceva_svcall.c:295 use userspace_s.signal_handler, which include/nuttx/userspace.h then does not declare.

Nobody can build or test a change to these files in the tree. Two ways forward:

  1. If the port is still in use: add ARCH_CEVA to arch/Kconfig and a board, then change the signal guards to CONFIG_ENABLE_ALL_SIGNALS.
  2. If not: remove arch/ceva.
Verification
  • I have verified before submitting the report.
Lenguaje dominante
C
Estrellas
4.1k
Forks
1.8k
Merge medio
1 d 5 h
PR fusionados (30 d)
841

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/nuttx

Todos los issues de apache/nuttx

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.