Forked executor closes caller-supplied stdout and stderr streams
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 68/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- java
- Área
- build-system
Línea de trabajo
Start in maven-executor/src/main/java/org/apache/maven/executor/support/ProcessBuilderExecutorSupport.java at lines 124 and 137, then compare stream handling in EmbeddedMavenExecutor.java at lines 293-294. Trace ExecutorRequest.Builder.stdOut() and stdErr() to confirm the ownership contract. Done means caller-supplied streams are flushed without being closed, shared stdout/stderr streams work, and the ownership behavior is documented.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Affected version
1.0.0
Bug description
ForkedMavenExecutor closes the OutputStream instances a caller passes through ExecutorRequest.Builder.stdOut() and stdErr(). Each pump thread wraps the stream in try-with-resources (ProcessBuilderExecutorSupport.java:124,137), so:
- A caller that hands the same stream to both
stdOut()andstdErr()to get one interleaved log, asmaven-verifierproduced, gets two threads racing to close it, and the secondtransferTocan fail with a closed stream. - A caller that passes
System.outor a stream it intends to keep using loses it after the first execution. EmbeddedMavenExecutorwraps the same streams inPrintStreaminstances (EmbeddedMavenExecutor.java:293-294) and does not close them, so the two executors treat ownership differently.
Found while porting maven-integration-testing and maven-surefire's IT fixtures from maven-verifier (apache/maven-verifier#186); both now wrap the log file in a stream with an idempotent close().
Proposal: the executor should not close streams it did not open. Flush them after the pump finishes and leave closing to the caller, and document that stdOut() and stdErr() may be the same stream. If closing has to stay for compatibility, document it in ExecutorRequest.Builder Javadoc.
- Lenguaje dominante
- Java
- Estrellas
- 5
- Forks
- 2
- Merge medio
- 4 h 22 min
- PR fusionados (30 d)
- 2
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de apache/maven-executor
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
apache/maven-executor#46 ·
-
bug
Dificultad 4/5 3-5 días Aptitud para principiantes 68/100
apache/maven-executor#50 ·
-
enhancement priority:major
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
apache/maven-executor#49 ·
-
bug
Dificultad 3/5 1-2 días Aptitud para principiantes 78/100
apache/maven-executor#48 ·
-
bug
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
apache/maven-executor#47 ·
Todos los issues de apache/maven-executor
Issues similares
-
area-deployment area-integrations triage:bot-seen
Dificultad 2/5 Medio día Aptitud para principiantes 86/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
apache/flink-agents#1156 ·
-
[source-shopify] FAILED bulk operation without partialDataUrl is silently treated as successful Abiertoarea/connectors autoteam community connectors/source/shopify needs-triage team/use type/bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100