Retry "already landed" check fails for an overwrite of an empty table, then deletes the landed snapshot's manifests

Abierto
  • ¿Algo no está bien?
#4,022 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

  • #4023 de @dancsi — cerrado sin fusionar

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
databases

Línea de trabajo

Start with Transaction.commit_transaction, especially the landed-snapshot check, and trace how Table.overwrite registers the delete and append producers. Use the reproduction in the issue to investigate the lost-response retry and cleanup behavior. Done means regression tests show the landed snapshot is recognized and its manifests remain available; the reporter says they already have a fix with tests.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Apache Iceberg version: 0.12.0 (also reproduced on main at ebbc0ba3e4)

Please describe the bug 🐞

After a failed attempt, Transaction.commit_transaction checks whether the attempt actually landed:

if all(
    self._table.metadata.snapshot_by_id(producer._snapshot_id) is not None
    for producer in self._snapshot_producers
):

A transaction can contain a producer that never creates a snapshot. Table.overwrite on an empty table (or any delete that matches nothing, followed by an append) registers a delete producer, but only the append produces an AddSnapshotUpdate. The delete producer's _snapshot_id never appears in the table, so the check is always false, even when the append landed.

pyiceberg then rebuilds and retries. On the rebuilt attempt, the delete producer's concurrency validation sees the transaction's own landed append as a concurrent conflicting write, and raises ValidationException. That goes to _clean_all_uncommitted(), which deletes the manifest list and manifests of the snapshot that landed.

Reproduction
import tempfile

import pyarrow as pa
from pyiceberg.catalog.sql import SqlCatalog
from pyiceberg.exceptions import CommitFailedException
from pyiceberg.schema import Schema
from pyiceberg.types import LongType, NestedField

warehouse = tempfile.mkdtemp()
catalog = SqlCatalog("default", uri=f"sqlite:///{warehouse}/catalog.db", warehouse=f"file://{warehouse}")
catalog.create_namespace("default")
table = catalog.create_table(
    "default.t",
    Schema(NestedField(1, "a", LongType(), required=False)),
    properties={"commit.retry.min-wait-ms": "0"},
)

# The catalog applies the first commit, but the client sees a failure.
commit_table = catalog.commit_table
calls = 0
def commit_table_lose_first_response(*args):
    global calls
    calls += 1
    response = commit_table(*args)
    if calls == 1:
        raise CommitFailedException("simulated lost response")
    return response
catalog.commit_table = commit_table_lose_first_response

try:
    table.overwrite(pa.table({"a": pa.array([1, 2, 3], pa.int64())}))
except Exception as e:
    print(f"overwrite raised: {type(e).__name__}: {e}")

table = catalog.load_table("default.t")
snapshot = table.current_snapshot()
print("manifest list exists:", table.io.new_input(snapshot.manifest_list).exists())
table.scan().to_arrow()

Output:

Commit failed due to a concurrent update, retrying (1/4) in 0 ms
overwrite raised: ValidationException: Added data files were found matching the filter for snapshots set()!
manifest list exists: False
FileNotFoundError: [Errno 2] Failed to open local file '.../metadata/snap-...avro'

The same overwrite with a response that isn't lost succeeds, and a plain append with a lost first response is correctly detected as landed.

Suggested fix

Base the check on the snapshots the attempt actually tried to add, i.e. the AddSnapshotUpdates in self._updates, rather than on every producer. Equivalently, skip producers that didn't produce a snapshot. Ideally, a ValidationException raised during a rebuild should also never clean up a snapshot that is present in the refreshed metadata.

Related: #4021, which covers the missing check on the last attempt.

Willingness to contribute
  • I would be willing to contribute a fix for this bug with guidance from the Iceberg community

I have a fix with regression tests for both this and #4021: it keys the landed check on the AddSnapshotUpdate snapshot ids that were sent, and runs it after every CommitFailedException, including on the last attempt. I'm happy to open a PR.

Lenguaje dominante
Python
Estrellas
1.2k
Forks
654
Merge medio
2 d 11 h
PR fusionados (30 d)
122

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/iceberg-python

Todos los issues de apache/iceberg-python

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.