[Bug] REST catalog drop_table serializes purgeRequested as "True" instead of "true"

Abierto Apto para principiantes
#3,836 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
78/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
api

Línea de trabajo

Empieza en pyiceberg/catalog/rest/init.py, en RestCatalog.drop_table, e inspecciona las otras apariciones de params= sugeridas en el issue. Reproduce la solicitud o ejecuta las comprobaciones relevantes del REST catalog; después, verifica que purgeRequested se serialice como true o false en minúsculas y que el servidor lo acepte.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Apache Iceberg version

None

Please describe the bug 🐞
### Description

`RestCatalog.drop_table()` passes a Python `bool` directly to `requests` query params. Python's `requests` library 
serializes `True` as the string `"True"` (capitalized). This violates the OpenAPI 3.0 specification for boolean 
query parameters and causes 400 errors on spec-compliant servers.

### Steps to Reproduce

```python
from pyiceberg.catalog import load_catalog

catalog = load_catalog("my_catalog", **{
    "type": "rest",
    "uri": "http://my-rest-catalog/iceberg",
    ...
})

catalog.drop_table("my_db.my_table", purge_requested=True)
# → 400 Bad Request

Evidence

Enabled wire-level logging via http.client.HTTPConnection.debuglevel = 1:
send: b'DELETE /iceberg/v1//namespaces/my_db/tables/my_table?purgeRequested=True HTTP/1.1\r\n...'

reply: 'HTTP/1.1 400 Bad Request\r\n'
header: x-amzn-errortype: purge_enabled
body: {"error":{"type":"BadRequestException","message":"purge_enabled: DropTable operation failed. OSS Tables only 
supports dropping tables with purge enabled."}}

The server receives purgeRequested=True (capital T) and does not interpret it as boolean true.

Root Cause

pyiceberg/catalog/rest/init.py, drop_table method (~line 1135):
def drop_table(self, identifier: str | Identifier, purge_requested: bool = False) -> None:
response = self._session.delete(
self.url(Endpoints.drop_table, prefixed=True, **self._split_identifier_for_path(identifier)),
params={"purgeRequested": purge_requested}, # Python bool True → requests serializes as "True"
)
Python's requests library calls str() on param values: str(True) → "True".

Why This Is a Bug

The Iceberg REST catalog OpenAPI spec (rest-catalog-open-api.yaml
(https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml)) defines purgeRequested as:
- name: purgeRequested
in: query
schema:
type: boolean
Per the specification chain:

"True" (capitalized) is not a valid serialization of a JSON boolean.

Suggested Fix
params={"purgeRequested": str(purge_requested).lower()},
Or more explicitly:
params={"purgeRequested": "true" if purge_requested else "false"},
Scope

This pattern may exist elsewhere in the REST catalog client. A grep for params={ in
pyiceberg/catalog/rest/init.py would identify other occurrences where Python bools are passed as query
parameters.

Environment

  • PyIceberg: 0.11.1
  • Python: 3.10.21
  • Server: Aliyun OSS Tables (Iceberg REST compatible, strictly validates boolean query params)
  • requests: 2.x (serializes bool via str())
Willingness to contribute
  • I can contribute a fix for this bug independently
  • I would be willing to contribute a fix for this bug with guidance from the Iceberg community
  • I cannot contribute a fix for this bug at this time
Lenguaje dominante
Python
Estrellas
1.1k
Forks
589
Merge medio
2 d 4 h
PR fusionados (30 d)
72

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/iceberg-python

Todos los issues de apache/iceberg-python

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.