[Bug] Cannot read properties of undefined (reading 'group') in blurSeries during React re-render

Abierto
#21,559 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
1/5
Tiempo estimado
Menos de una hora
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Tranquilo
Stack tecnológico
next.js, react, typescript

Línea de trabajo

Comienza en src/util/states.ts, en blurSeries, y compara su acceso a view con el acceso protegido de toggleSeriesBlurState. Reproduce la secuencia de re-renderizado de React y mouseover, y luego verifica que se omita la vista de una serie eliminada sin un TypeError.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

en pending
Version

6.0.0

Link to Minimal Reproduction

N/A — race condition during React component re-render

Steps to Reproduce
  1. Render an ECharts chart (Sankey, Bar, Treemap) inside a React component
  2. Use notMerge: true with echarts-for-react
  3. Trigger a data change that causes React to re-render the chart (e.g., toggling filter buttons)
  4. While the chart is re-rendering, move the mouse over the chart area
Current Behavior

Runtime TypeError:

Cannot read properties of undefined (reading 'group')

Stack trace:

blurSeries (echarts/lib/util/states.js:362)
  → var view = api.getViewOfSeriesModel(seriesModel);
  → view.group.traverse(...)  // 💥 view is undefined

handleGlobalMouseOverForHighDown (states.js:499)
Handler.<anonymous> (echarts.js:1549)
Eventful.trigger (zrender/Eventful.js:103)
Handler.dispatchToElement (zrender/Handler.js:148)
Handler.mousemove (zrender/Handler.js:101)
HandlerDomProxy.mousemove (zrender/HandlerProxy.js:90)
HTMLDivElement.<anonymous> (zrender/HandlerProxy.js:209)
Expected Behavior

No crash. The blur effect should be skipped gracefully when the series view has been disposed.

Root Cause

In blurSeries() (src/util/states.ts), api.getViewOfSeriesModel(seriesModel) can return undefined when a series model still exists in the GlobalModel but its view has been disposed during a React re-render cycle (via setOption with notMerge or component unmount). The code unconditionally accesses view.group:

const view = api.getViewOfSeriesModel(seriesModel);
view.group.traverse(function (child) {  // ← crashes if view is undefined

This is the same class of bug as #9402 and #21535 — stale references to disposed series during mouse events.

Suggested Fix

Add a null guard after the view lookup:

const view = api.getViewOfSeriesModel(seriesModel);
if (!view || !view.group) {
    return;
}
view.group.traverse(function (child) {

This follows the same pattern used elsewhere in the codebase (e.g., toggleSeriesBlurState already guards view access).

I will submit a PR with this fix.

Environment
Item Value
OS macOS
Browser Chrome
Framework React 19 + Next.js 16
echarts-for-react 3.0.6
Lenguaje dominante
TypeScript
Estrellas
67.7k
Forks
19.9k
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/echarts

Todos los issues de apache/echarts

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.