[Enhancement] Constant LIKE/REGEXP pattern is recompiled for every clone of the expression (per scanner and per segment iterator)

Abierto
  • ¿Algo no está bien?
#69,916 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp, sql
Área
databases, performance

Línea de trabajo

Start from FunctionLike and FunctionRegexpLike in the backend expr code, where THREAD_LOCAL open compiles the pattern. Read VExprContext::clone and SegmentIterator::_construct_compound_expr_context to see per-clone opens. Implement FRAGMENT_LOCAL compilation storing state in FunctionContext, then reuse via hs_clone_scratch. Validate with the provided REGEXP SQL on a many-segment table; done when open phase no longer scales with segments.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Search before asking
  • I had searched in the issues and found no similar issues.
Version

master (checked at 5b2c066b4d), branch-4.1, 4.1.5

What's wrong?

FunctionLike and FunctionRegexpLike build their state, including the Hyperscan database (hs_compile) or the RE2/Boost regex for a constant pattern, only in their THREAD_LOCAL open. VExprContext::clone opens THREAD_LOCAL again for every clone, and a pushed-down predicate is cloned once per scanner and once per segment iterator (SegmentIterator::_construct_compound_expr_context). A scan over N segments therefore compiles the same constant pattern about N times.

A case-insensitive alternation such as (?i)(alpha|bravo|...|juliet)[.](exe|dll)$ takes milliseconds to compile. On a table with about ten thousand segments, the open phase (SegmentIteratorInitTimer in the profile) dominates the query and costs minutes of CPU. Matching itself (ExprFilterEvalTime) stays in the tens of milliseconds.

LikeSearchState::clone, used by LikeColumnPredicate, also runs hs_prepare again for each clone.

What you expected to happen

A constant pattern is compiled once per fragment, and its clones reuse it.

How to reproduce
CREATE TABLE t (k BIGINT, s STRING) DUPLICATE KEY(k) DISTRIBUTED BY HASH(k) BUCKETS 64
PROPERTIES ('replication_num' = '1', 'disable_auto_compaction' = 'true');
-- 60 times:
INSERT INTO t SELECT number, concat('file', cast(number AS STRING), '.exe') FROM numbers('number' = '5000');

SELECT count(*) FROM t WHERE s REGEXP 'file1[.]exe$';
SELECT count(*) FROM t WHERE s REGEXP '(?i)(alpha|bravo|charlie|delta|echo|foxtrot|golf|hotel|india|juliet|file1)[.](exe|dll)$';

With about 3.9k rowsets on one BE, the second query takes about 150 ms against about 72 ms for the first: about 77 ms of compiling. With the change below, both take about 47 ms. The gap grows linearly with the segment count.

Anything else?

Proposed change:

  • In the FRAGMENT_LOCAL open, compile a constant pattern and store it as fragment state. FunctionContext::clone() already shares that state.
  • In the THREAD_LOCAL open, share the fragment's Hyperscan database, which is read-only once compiled, and give each state its own scratch through hs_clone_scratch.
  • Keep compiling RE2 and Boost per state, because RE2 locks its lazily built DFA cache on every search, so one shared RE2 would serialise matching across scanner threads.
  • Non-constant patterns keep the current per-call path.
  • LikeSearchState::clone shares the database the same way.

Scope: this applies to LIKE/REGEXP, the only functions that compile a single pattern with Hyperscan. regexp_count, regexp_replace, regexp_extract and split_by_regexp also compile per THREAD_LOCAL open, but they use RE2. Building an RE2 is much cheaper than hs_compile, and sharing one RE2 across clones would contend on its DFA cache lock, so they are better left compiling per clone.

Related: #68977

Are you willing to submit PR?
  • Yes I am willing to submit a PR!
Code of Conduct
Lenguaje dominante
Java
Estrellas
16.2k
Forks
4k
Merge medio
1 d 19 h
PR fusionados (30 d)
671

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/doris

Todos los issues de apache/doris

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.