Aggregate spill: List<Dictionary> state whose values repeat within a group still fails under a memory limit

Abierto
  • ¿Algo no está bien?
#27,240 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
53/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust, sql
Área
data-engineering, databases

Línea de trabajo

Start with #25853 and the spill and replay handling for List<Dictionary> state, especially how SpilledRowSizes estimates referenced values. Reproduce the failure with the provided datafusion-cli -m 24M query, then trace the aggregate spill path and its tests. Done means the query completes under a limit sufficient for one group without causing excessive spill growth when groups share values.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
Describe the bug

An aggregate whose state holds a large dictionary can still fail with Failed to allocate additional ... after #25853 (which fixes #25851), when the dictionary values repeat within a group but not across groups. #25853 sizes a dictionary by the values its keys reference only when fewer than two keys reference each value on average; otherwise it counts the keys only and leaves the dictionary shared, as on main. A dictionary whose values repeat a few times within a group, but whose groups share no values, takes the shared path, and spill and replay batches still carry the whole dictionary.

To Reproduce

Measured with datafusion-cli (release-nonlto) at the head of #25853 (29c666126):

SET datafusion.execution.target_partitions = 1;
SELECT count(*), sum(n) FROM (
  SELECT (v / 10) % 32 AS k,
         cardinality(array_agg(arrow_cast(concat(CAST(v / 10 AS VARCHAR), repeat('x', 100)), 'Dictionary(Int32, Utf8)'))) AS n
  FROM generate_series(1, 5000000) AS t(v)
  GROUP BY (v / 10) % 32);

datafusion-cli -m 24M fails with Failed to allocate additional 24.7 MB for SingleHashAggregateStream[0] with 0.0 B already allocated for this reservation. It passes at -m 64M.

Changing only how often each value repeats in a group (v / 10 in both places):

repeats per value -m 24M
2 passes
10 fails
50 passes

With 1000-byte values and target_partitions = 2, the final aggregate fails at -m 24M (Failed to allocate additional 16.8 MB for FinalHashAggregateStream[0]). With 1000-byte values and target_partitions = 1 over 2M rows, it fails at both 24M and 64M.

Expected behavior

The query completes under a memory limit large enough for one group, as the other repeat counts do.

Additional context

Compacting the dictionary of each spilled chunk would be cheap here, but whether it pays off depends on whether the groups share their values. If they do, each chunk writes its own copy and the spill file grows, which is why #25853 doesn't compact every dictionary (array_agg over 100 distinct 200-byte values spilled 371 MB, against 14.7 MB without compaction). Telling the two cases apart needs the number of distinct values referenced per row, which SpilledRowSizes doesn't track for List<Dictionary>.

Related: #25851, #25853, #26711.

Willingness to contribute

I would like to contribute a fix for this bug, but request guidance from the DataFusion community

Lenguaje dominante
Rust
Estrellas
9.6k
Forks
2.6k
Merge medio
3 d 4 h
PR fusionados (30 d)
345

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/datafusion

Todos los issues de apache/datafusion

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.