[Bug] hll_* errors surface as Comet errors instead of HLL_INVALID_INPUT_SKETCH_BUFFER / HLL_UNION_DIFFERENT_LG_K

Abierto
  • ¿Algo no está bien?
#7,549 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust, scala, spark
Área
backend, testing

Línea de trabajo

Start with native/common/src/error.rs and the spark-4.x ShimSparkErrorConverter, then inspect nearby error conversion tests and HLL SQL tests. Reproduce the invalid-buffer query and the different-lgConfigK case against Spark and Comet. Done means both cases expose Spark’s specified error condition and SQLSTATE, with regression coverage.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:expressions bug priority:low
Describe the bug

When the native HLL expressions fail, Comet raises a plain Comet execution error instead of Spark's SparkRuntimeException with the HLL error condition. Both engines fail on the same inputs, but the error class, SQLSTATE and message differ.

Expression Spark error condition (SQLSTATE)
hll_sketch_estimate, hll_union, hll_union_agg on an invalid buffer HLL_INVALID_INPUT_SKETCH_BUFFER (22546)
hll_union, hll_union_agg with different lgConfigK and allowDifferentLgConfigK = false HLL_UNION_DIFFERENT_LG_K (22000)

native/common/src/error.rs SparkError has no HLL variant, so these errors cannot reach SparkErrorConverter / ShimSparkErrorConverter.

Steps to reproduce
SELECT hll_sketch_estimate(X'0102030405');

Spark 4.x raises [HLL_INVALID_INPUT_SKETCH_BUFFER] Invalid call to hll_sketch_estimate; only valid HLL sketch buffers are supported as inputs ... with SQLSTATE 22546. Comet raises a Comet execution error with a different message.

Expected behavior

Comet raises the same error condition and SQLSTATE as Spark. A likely fix, following https://github.com/apache/datafusion-comet/issues/5072 :

  • add SparkError variants for the two conditions in native/common/src/error.rs;
  • map them in the spark-4.x ShimSparkErrorConverter to QueryExecutionErrors.hllInvalidInputSketchBuffer(function) and QueryExecutionErrors.hllUnionDifferentLgK(left, right, function);
  • cover them with expect_error_class SQL tests or checkSparkError.
Additional context

Surfaced by the HLL audit for https://github.com/apache/datafusion-comet/issues/7396 . The comparison experiment confirmed both engines fail on the same inputs ( https://github.com/apache/datafusion-comet/issues/7396#issuecomment-6703600973 ). The serdes currently list this as an incompatible reason that is never returned; the audit PR moves it to a compatibility note that links here.

Willingness to contribute

I can contribute a fix for this bug independently

Lenguaje dominante
Scala
Estrellas
1.3k
Forks
414
Merge medio
3 d 5 h
PR fusionados (30 d)
210

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/datafusion-comet

Todos los issues de apache/datafusion-comet

Issues similares

Más issues de Scala

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.