Research lightweight handling of panicking wakers
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start by reading issues #341 and #335 to understand the current non-panicking contract and the complexity that was removed. Compare the linked Tokio, thingbuf, event-listener, embassy-sync, and asupersync approaches, then produce a small prototype with targeted validation. Done means an evidence-backed proposal or documented conclusion that preserves ownership and unwind safety without adding dependencies or complicating the normal path.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Motivation
Follow-up to #341, with the earlier discussion in #335. Asyncband currently expects executor waker operations to be non-panicking and does not promise recovery from panicking waker operations. Removing the previous recovery machinery made notification and permit-distribution paths substantially easier to follow.
A wake callback can still panic after a batch of waiters has been detached, interrupting the remaining notifications. Investigate whether we can attempt those remaining wakes with a small, clear implementation, without restoring the complexity removed in #341.
Research questions
- Which real-world executor or custom-waker scenarios benefit from recovery, and what behavior should callers observe after catching the panic?
- Can an ownership or RAII-based approach provide useful recovery? Distinguish cleaning up remaining wakers from actually waking them, and account for a later wake also panicking or cleanup running during an existing unwind.
- What state must be committed before invoking callbacks, especially for permit distribution and cancellation handoff?
- Where should the recovery boundary be? Focus on
wakeandwake_by_ref; assesscloneanddropwhere they affect the proposed approach, rather than assuming that every waker operation needs a general recovery framework. - What are the costs in code complexity, allocation, and the normal notification path?
Existing examples
The initial source review found several different policies rather than one ecosystem-wide convention:
- Tokio 1.53.1 WakeList uses a drop guard to destroy remaining wakers after a wake panic; it does not attempt the remaining wakes. Its internal AtomicWaker separately restores registration state after a clone panic.
- thingbuf 0.1.6 WaitCell follows Tokio's registration-recovery strategy, while its batch queue notifications directly invoke callbacks.
- event-listener 5.4.2 directly invokes wake callbacks in its notification loop, without per-callback panic isolation. async-lock, async-channel, and async-broadcast build on this notification mechanism.
- embassy-sync 0.8.0 MultiWakerRegistration clears the stored length before waking to preserve memory safety during unwinding; a panic stops the loop and can leak the remaining wakers.
- asupersync 0.5.0 Notify catches each wake panic, retains the first payload, attempts the remaining wakes, and then resumes the first panic. This is a concrete comparison point for the stronger behavior and its implementation cost.
Desired outcome
An evidence-backed proposal with a small prototype and targeted validation, or a documented conclusion explaining why the available approaches do not justify their complexity. Keep callbacks and replaced or cancelled waker destruction outside primitive locks, preserve basic ownership and unwind safety, introduce no new dependencies, and keep the normal path simple.
A successful approach is intended to be a non-breaking robustness improvement under the contract established by #341. Broader guarantees for arbitrary panicking waker operations should be justified separately.
- Lenguaje dominante
- Rust
- Estrellas
- 274
- Forks
- 42
- Merge medio
- 20 h 18 min
- PR fusionados (30 d)
- 55
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de apache/asyncband
-
enhancement good first issue help wanted
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
apache/asyncband#324 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
enhancement question
Dificultad 5/5 Más de una semana Aptitud para principiantes 30/100
apache/asyncband#312 · 3 comentarios ·
Los mantenedores suelen responder en 1 día
-
enhancement help wanted
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 30/100
apache/asyncband#272 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
Explore ManualResetEvent waiter storage and state fast pathsQuizá libre de nuevo Un pull request para esta issue se cerró sin fusionarse. Abiertoenhancement good first issue help wanted
Dificultad 5/5 Más de una semana Aptitud para principiantes 38/100
apache/asyncband#252 · 1 comentario ·
Los mantenedores suelen responder en 1 día
Todos los issues de apache/asyncband
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 4 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
Los mantenedores suelen responder en 1 día
-
Update dusk-bls12_381 to 0.16Posiblemente ocupada @HDauven la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
-
`TcpListenerService` shares one `Extensions` store across all accepted connectionsPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
googlefonts/fontquant#43 ·