Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

feat(date/timepicker): Enhance DateAdapter to accept diffetent types for date and time

Abierto
  • ¿Algo no está bien?
#33,276 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Necesita aclaración
Estado de actividad
Tranquilo
Stack tecnológico
angular, typescript
Área
frontend

Línea de trabajo

Empieza siguiendo la API de DateAdapter hasta los puntos de entrada de date picker y time picker. Compara las suposiciones compartidas actuales sobre fecha/hora con los tipos de fecha y hora separados solicitados, el manejo de valores no válidos y el comportamiento de addSeconds/setTime. Se considera terminado cuando exista un diseño de API compatible con versiones anteriores y un plan de implementación que admita LocalDate/PlainDate con LocalTime/PlainTime sin casts inseguros.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: material/datepicker feature gemini-triaged P3
Feature Description

Currently DateAdapter is designed to work with instances of the same time for date and time, this is how JavaScript Date works and many other replacement libraries do too. Many libraries have noticed this is not always desirable. Java got the external Joda-Time library that became the model for the modern java.time replacement. On the JavaScript side I use js-joda, a port of the original Java Joda-Time library

Much like the new Temporal API, these libraries have aditional split representations of a date and a time, LocalDate and LocalTime and LocalDateTime when you need both without a timezone attached to it.

The Temporal API, brings these kind of types to JavaScript with PlainDate, PlainTime and PlainDateTime (better naming than the Local prefix).

DateAdapter is not designed to have a date picker with a LocalDate/PlainDate and a time picker with a LocalTime/PlainTime. Yes you can make it work but it requires a few hacks, for example the time parts on my js-joda adapter.

  isDateInstance(obj: unknown): boolean {
    return obj instanceof LocalDate || obj instanceof LocalTime;
  }

  isValid(date: LocalDate): boolean {
    return date !== INVALID_VALUE;
  }

  invalid(): LocalDate {
    return INVALID_VALUE;
  }

  override compareDate(first: LocalDate, second: LocalDate): number {
    return first.compareTo(second);
  }

  override sameDate(first: LocalDate | null, second: LocalDate | null): boolean {
    if (first != null && second != null) {
      // WORKAROUND to allow generating the list of times in the time picker
      if (first instanceof LocalTime && second instanceof LocalTime) {
        return true;
      }
      return first.equals(second);
    }
    return (first ?? null) === (second ?? null);
  }

  override setTime(_target: LocalDate, hours: number, minutes: number, seconds: number): LocalDate {
    return LocalTime.of(hours, minutes, seconds) as unknown as LocalDate;
  }

  override getHours(date: LocalDate): number {
    return (date as unknown as LocalTime).hour();
  }

  override getMinutes(date: LocalDate): number {
    return (date as unknown as LocalTime).minute();
  }

  override getSeconds(date: LocalDate): number {
    return (date as unknown as LocalTime).second();
  }

  override addSeconds(date: LocalDate, amount: number): LocalDate {
    const time = date as unknown as LocalTime;

    const remainingSeconds = SECONDS_PER_DAY - time.toSecondOfDay();
    if (remainingSeconds < amount) {
      return INVALID_VALUE;
    }

    return time.plusSeconds(amount) as unknown as LocalDate;
  }

Notice there is a lot of unsafe casting because the subclass extends DateAdapter<LocalDate>, it will have less casting if it was DateAdapter<LocalDate | LocalTime> but that would need more type checks on methods exclusively used by the date picker.

The API changes required are resumed in:

  • The adapter should be split in two or have a different type for the time. I prefer to split the adapter, because that way there could be multiple combinations of adapters for PlainDate, PlainTime, Instant (for date and for time pickers) in Temporal API for example.
  • js-joda/Temporal API has no concept of an invalid Local/Plain object, their constructors throw exceptions, So I have to hack a fake date INVALID_VALUE as an specific instance with a very big year, to use as an invalid value. So the logic that requires an invalid value should change, for example the time picker uses isValid() to stop the loop that builds the times to show.
  • addSeconds()and setTime() should not tie a time to date ever, if possible start with a start time.

Making these changes backward compatible will be a challenge, but I think it is needed to make usable the Temporal API Plain classes with the pickers.

Use Case

No response

Lenguaje dominante
TypeScript
Estrellas
25k
Forks
6.8k
Merge medio
1 d 7 h
PR fusionados (30 d)
92

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de angular/components

Todos los issues de angular/components

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.