Not possible to swipe/drag Sheet component with mouse cursor

Abierto
  • ¿Algo no está bien?
#10,749 8 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
react, typescript
Área
frontend

Línea de trabajo

Start by reproducing the bug on the Sheet snap-points example linked in the report, then find where the Sheet's drag gesture is handled and check whether it responds to touch input only and not to mouse pointer drags. Read the six-comment thread first, since the expected visual handle hover and dismiss threshold may already have been discussed. Done means mouse-dragging the handle expands or shrinks the sheet and dismisses it past the threshold, and the existing Sheet tests still pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Provide a general summary of the issue here

Great work on the new Sheet component (blog post)!

I wanted to try it out immediately on my laptop, and discovered that I wasn't able to drag/swipe the Sheet with my mouse cursor. Pressing down on the left mouse button and dragging didn't seem to do anything, no matter where the drag started. This felt very unexpected, especially as many of the examples included a drag handle.

🤔 Expected Behavior?

I expect mouse down + dragging the sheet handle (when rendered) to expand/shrink the sheet, and close/dismiss it when shrunk to a certain threshold. The drag handle could probably also use some kind of visual indicator on hover to indicate that it is in fact interactive.

😯 Current Behavior

Mouse initiated dragging doesn't appear to be supported at all.

💁 Possible Solution

No response

🔦 Context

Trying to ensure that mouse users get the UX that is commonly associated with a Sheet component.

🖥️ Steps to Reproduce
  1. Visit https://react-aria.adobe.com/Sheet#snap-points on a computer with mouse connected
  2. Press "Show place"
  3. Wait for Sheet to open
  4. Mouse down on the sheet handle at the top of the sheet
  5. Drag mouse up/down
  6. Nothing happens
Version

v1.22.0

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Mac OS

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

Lenguaje dominante
TypeScript
Estrellas
16k
Forks
1.6k
Merge medio
2 d 17 h
PR fusionados (30 d)
41

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de adobe/react-spectrum

Todos los issues de adobe/react-spectrum

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.