Surface the Outdated phase, and tell a runner version deprecation apart from a rejected spec

Abierto
#4,739 1 comentario 4 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
github-actions, go, kubernetes, prometheus

Línea de trabajo

Start by tracing how the controller handles runner exit code 7 and updates AutoscalingRunnerSet status to Outdated; inspect the related changes in #4652 and #4660. Then find where controller metrics and Kubernetes Events are registered, and how runner version information is available. Done means Outdated sets emit a Warning Event and phase metric, while version deprecation is recorded distinctly in status.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happens

When GitHub deprecates a runner version, the runner exits 7 and the AutoscalingRunnerSet goes
Outdated. On 0.14.1 that deleted the scale set. On 0.15.x (#4652, #4660) it is switched off
until the runner spec changes, which is better. Two gaps remain:

  1. Nothing signals it. The controller records no Kubernetes Event, exports no metric for the
    phase, and the listener (the source of the gha_* metrics) is stopped. Jobs for the label
    queue without any error. We found two outages only when users reported stuck jobs, days later.
  2. A version deprecation looks the same as a rejected spec. The recovery differs: for a
    deprecation, the fix is a newer actions-runner image, and the spec was valid the day before.
Request
  • Record a Warning Event on the AutoscalingRunnerSet when it enters Outdated, and expose its
    phase as a controller metric (for example gha_autoscaling_runner_set_phase{phase}).
  • Carry the reason in status, for example a condition with reason RunnerVersionDeprecated and
    the runner version, when exit code 7 comes from a version deprecation.
Workaround

kube-state-metrics custom resource metrics on status.phase, plus an alert on
phase != Running for 10 minutes.

Controller and chart 0.14.1. Behavior checked against the 0.15.1 source.

Lenguaje dominante
Go
Estrellas
6.7k
Forks
1.5k
Merge medio
1 h 34 min
PR fusionados (30 d)
5

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de actions/actions-runner-controller

Todos los issues de actions/actions-runner-controller

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.