Rework TrajectoryReporter

Abierto
#536 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
python
Área
data

Línea de trabajo

Start by reading TrajectoryReporter and the report and _configure_reporter behavior described in the issue, then review the linked H5MD issue (#19) for compatibility requirements. The scope and preferred design are not settled here, so clarify the expected API before changing code. Done means the reporter supports the agreed H5MD and model-property reporting needs.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

That is currently the default behavior but it's a bit convoluted. If no reporter is given:

static will make one when _configure_reporter is called.
When calling report the file IO will be bypassed in favor of a concatenation as you describe.
TrajectoryReporter probably needs a rework. Both to make it compatible with h5md (https://github.com/TorchSim/torch-sim/issues/19) and to make it easier to report out model properties, as you've identified.

For the latter, the simplest solution (perhaps not the best) would be to add the model_outputs as a optional kwarg to the report function so that model predictions can be covered by the current API without needing an additional call.

Originally posted by @orionarcher in https://github.com/TorchSim/torch-sim/pull/464#discussion_r2867761319

Lenguaje dominante
Python
Estrellas
502
Forks
108
Merge medio
1 d 1 h
PR fusionados (30 d)
12

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TorchSim/torch-sim

Todos los issues de TorchSim/torch-sim

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.