Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Clock period improvements left on the table due to SYNTH_MINIMUM_KEEP_SIZE counting macros

Abierto
  • ¿Algo no está bien?
#4,714 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@joaomai ya está trabajando en esto.

Desde el 22/10/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Description

SYNTH_MINIMUM_KEEP_SIZE decides which modules hierarchical synthesis keeps. The expectation is that it measures the logic yosys works on: since @povik's #2552 the decision is keep_hierarchy -min_cost on yosys's cost estimate of each module, in NAND2 equivalents.

A macro is no work for yosys, but it counts. keep_hierarchy -min_cost needs a cost for every instanced blackbox, and convert_liberty_areas gives each Liberty cell, SRAM macros included, the gate equivalent of its area; since #4650 an AUTO_MEMORIES macro gets its generated view's area the same way. A small wrapper around macros therefore looks like a large module of logic and is kept, and its boundary stays wherever a path runs through it.

Example, asap7/riscv32i (SYNTH_MINIMUM_KEEP_SIZE=10000): the only module kept is dmem, four fakeram7_256x32 instances (1,376 µm² of Liberty area) and 56 µm² of address decode. Its boundary sits on the worst path, between the ALU's address adder and the SRAMs' enable decode, which synthesis then optimises apart. Through global route at 780 ps:

min reg2reg period reg2reg endpoints within 10 % of it: faster / slower
today: dmem kept 835.6 ps –
dmem flattened, which is what the rule decides with macro cost 0 791.8 ps 995 / 3

Details and the measurement in #4713 (closed, FYI only).

Suggested Solution

Make the rule measure what it is for: a blackbox macro, Liberty or AUTO_MEMORIES, costs 0 (or 1) gate equivalents towards its parent's size. keep_hierarchy -min_cost still has a cost for every blackbox, so the error that made a cost necessary does not come back.

The designs this can change are those that synthesise hierarchically with a keep threshold and have macros (make print-* on master; the gf12 designs not checked): asap7/coralnpu, asap7/riscv32i; nangate45/ariane133, ariane136, black_parrot, bp_be_top, bp_fe_top, bp_multi_top, bp_quad, mempool_group, tinyRocket. Their keep decisions change only where a macro sits under a module the rule would otherwise flatten, and their QoR may move either way.

Additional Context

variables.yaml describes the threshold as an area in NAND2 units. Stating there which is intended, the logic yosys works on or area including macros, would make the behaviour less surprising either way.

Lenguaje dominante
Verilog
Estrellas
767
Forks
544
Merge medio
2 d 3 h
PR fusionados (30 d)
96

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de The-OpenROAD-Project/OpenROAD-flow-scripts

Todos los issues de The-OpenROAD-Project/OpenROAD-flow-scripts

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.