TextArea (soft_wrap=False) cuts off the end of a line that has double-width characters before a tab

Abierto
#6,779 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
frontend

Línea de trabajo

Start by comparing Document.get_size() with TextArea's expand_tabs_inline path, then run the supplied reproduction with 中中\tEND and soft_wrap=False. Done means the measured width matches the drawn cell width and the full line, including END, is visible; the reporter says they already have a PR with a test ready.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Hi! I hit this while writing generated tests against Textual's widgets.

With soft_wrap=False, TextArea sets its virtual width from Document.get_size(), which measures each line with cell_len(line.expandtabs(tab_width)). str.expandtabs counts a double-width character as one column, so after CJK text the tab stops land in a different place from where TextArea draws them (it uses expand_tabs_inline, which counts cells). The width can come out too small, and then the end of the line can't be seen or scrolled to.

import asyncio

import textual
from textual.app import App, ComposeResult
from textual.widgets import TextArea

TEXT = "中中\tEND"  # 中中 is 4 cells, the tab pads to column 8, then END: 11 cells

class TextAreaApp(App):
    def compose(self) -> ComposeResult:
        yield TextArea(TEXT, soft_wrap=False, show_line_numbers=False, tab_behavior="indent")

async def main() -> None:
    app = TextAreaApp()
    async with app.run_test(size=(40, 5)) as pilot:
        text_area = app.query_one(TextArea)
        await pilot.pause()
        print("indent_width:", text_area.indent_width)
        print("first line on screen:", repr(text_area.render_line(0).text.rstrip()))
        print("screenshot contains 'END':", "END" in app.export_screenshot())
        print("document.get_size():", text_area.document.get_size(text_area.indent_width))
        print("virtual_size:", text_area.virtual_size)
    print("Textual", textual.__version__)

asyncio.run(main())

Output on Textual 8.2.7 (and the same on main at 5e5b7ef):

indent_width: 4
first line on screen: '中中    EN'
screenshot contains 'END': False
document.get_size(): Size(width=9, height=1)
virtual_size: Size(width=10, height=1)

The TextArea is 40 cells wide, but the "D" is never drawn: expandtabs puts the tab stop at column 4 (counting 中中 as 2 columns), so the line measures 9 cells instead of 11. I expected get_size() to measure tabs the same way the line is drawn. Using expand_tabs_inline there gives Size(width=11, height=1) and the whole line shows. I have a PR with a test ready.

Lenguaje dominante
Python
Estrellas
37.7k
Forks
1.5k
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Textualize/textual

Todos los issues de Textualize/textual

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.