Clicking the Header makes it tall, but `Header.tall` stays False

Abierto
#6,771 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
frontend

Línea de trabajo

The header widget lives in src/textual/widgets/_header.py; read _on_click there next to watch_tall, which is what actually applies the -tall class when the reactive changes. Run the snippet from the issue against a checkout to confirm the mismatch, then check the existing header tests (and snapshot tests under tests/) for where to add a regression case. Done means a click sets tall to True and header.tall = False shrinks the header back to one line. Note the reporter says a PR with a test is already prepared, so coordinate before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Hi! I hit this while writing generated tests against Textual's widgets.

Header._on_click toggles the -tall class directly, rather than the tall reactive that watch_tall uses to set that class. So after a click the header is drawn tall but tall is still False, and header.tall = False does nothing, because the value hasn't changed.

import asyncio

import textual
from textual.app import App, ComposeResult
from textual.widgets import Header

class HeaderApp(App):
    def compose(self) -> ComposeResult:
        yield Header()

async def main() -> None:
    app = HeaderApp()
    async with app.run_test() as pilot:
        header = app.query_one(Header)
        await pilot.pause()
        print(f"start:              tall={header.tall} height={header.size.height} classes={sorted(header.classes)}")
        await pilot.click(offset=(40, 0))  # on the title
        await pilot.pause()
        print(f"after click:        tall={header.tall} height={header.size.height} classes={sorted(header.classes)}")
        header.tall = False
        await pilot.pause()
        print(f"after tall = False: tall={header.tall} height={header.size.height} classes={sorted(header.classes)}")
    print("Textual", textual.__version__)

asyncio.run(main())

Output on Textual 8.2.7 (and the same on main at 5e5b7ef):

start:              tall=False height=1 classes=[]
after click:        tall=False height=3 classes=['-tall']
after tall = False: tall=False height=3 classes=['-tall']

I expected tall=True after the click, and the header to go back to one line after header.tall = False. Toggling the reactive in _on_click (self.tall = not self.tall) gives that, and I have a PR with a test ready if you'd like it.

Lenguaje dominante
Python
Estrellas
37.7k
Forks
1.5k
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Textualize/textual

Todos los issues de Textualize/textual

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.