ssr.nonce set after the router is created no longer reaches the hydration scripts (regression in 1.171.31)

Abierto
#8,789 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@aliassar ya está trabajando en esto.

Desde el 3/11/2026.

  • #8790 de @sarankumar1325 — cerrado sin fusionar
  • #8859 de @aliassar — abierto

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
react, typescript

Línea de trabajo

Start in packages/router-core/src/ssr/ssr-server.ts at the attachRouterServerSsrUtils code linked in the issue, and trace how the hydration state and inline scripts read router.options.ssr?.nonce. Compare that with the earlier per-script reads described in the issue. Done when the hydration and trailing inline scripts use a nonce set in the createStartHandler callback, with the regression reproducer confirming hydration succeeds under nonce-based CSP.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Which project does this relate to?

Start

Describe the bug

Since router-core 1.171.31 (#8204), attachRouterServerSsrUtils reads router.options.ssr?.nonce once, when it creates the request's hydration state:

https://github.com/TanStack/router/blob/94d6d8e4/packages/router-core/src/ssr/ssr-server.ts#L406

Before #8204, injectScript and the $tsr barrier script read it each time they wrote a script, so an app could set the nonce after the router was created, for example in the createStartHandler callback. Now the hydration <script data-tsr-stream-part> and the trailing inline <script> render without a nonce, a nonce-based CSP blocks them, and hydration fails with TypeError: Cannot set properties of undefined (setting 't'). The module script still gets the nonce, and nothing fails on the server.

// src/server.ts
const startFetch = createStartHandler((ctx) => {
  const nonce = crypto.randomUUID()
  ctx.router.options.ssr = { ...ctx.router.options.ssr, nonce }
  // ...set `Content-Security-Policy: script-src 'nonce-${nonce}' 'strict-dynamic'`
  return defaultStreamHandler(ctx)
})
Complete minimal reproducer

https://github.com/TrevorBurnham/tanstack-nonce-repro

Steps to Reproduce the Bug
  1. Set ssr.nonce in the createStartHandler callback as above, and send a CSP with script-src 'nonce-<n>'.
  2. Build and serve with router-core 1.171.30 (react-start 1.168.54). Every inline script has the nonce and the page hydrates.
  3. Upgrade to router-core 1.171.31 (react-start 1.168.55). The two inline scripts lose the nonce, the console reports two CSP violations and the TypeError, and the page content disappears. Still present in react-start 1.169.3 (router-core 1.171.38).

Setting the nonce in getRouter() (passing it in as request context) works around it.

Expected behavior

Either the hydration scripts pick up a nonce set any time before rendering, as before, or the docs say ssr.nonce must be set when the router is created, and a dev-mode warning catches a nonce that changes after the SSR utilities are attached.

Platform
  • Router / Start Version: router-core 1.171.31 through 1.171.38 (last working: 1.171.30)
  • OS: macOS, Linux (AWS Lambda)
  • Browser: Chrome
  • Bundler: vite 8.2.1
Lenguaje dominante
TypeScript
Estrellas
15.3k
Forks
1.9k
Merge medio
1 d 5 h
PR fusionados (30 d)
46

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TanStack/router

Todos los issues de TanStack/router

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.