Start SSR enters infinite 307 loop when custom search serializer emits comma-delimited arrays

Abierto
#8,777 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@pavstev ya está trabajando en esto.

Desde el 3/11/2026.

  • #8782 de @mixelburg — cerrado sin fusionar
  • #8848 de @pavstev — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
57/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
react, typescript
Área
backend

Línea de trabajo

Start in the loadServerRoute and getNormalizedURL code paths described in the issue, then compare how each constructs and compares the request URL for comma and %2C query values. Use the linked StackBlitz reproduction or the provided curl command to observe the repeated 307 redirects. Done means the request converges without redirecting forever, including when the router's rewrite option is used.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Which project does this relate to?

Router

Describe the bug

TanStack Start SSR can enter an infinite self-redirect loop when a custom stringifySearch emits comma-delimited arrays.
For GET /test?tags=1,2, server URL normalization serializes the query as tags=1%2C2. The configured parser and route's validateSearch turn this into tags: ['1', '2'], then the configured stringifier canonicalizes it back to the literal-comma form, /test?tags=1,2.
loadServerRoute compares the normalized next.publicHref with the canonical publicHref, sees %2C and , as different, and redirects to canonical publicHref with 307 Location: /test?tags=1,2. The redirected request repeats the same process indefinitely. Browser show ERR_TOO_MANY_REDIRECTS.

Complete minimal reproducer

https://stackblitz.com/edit/github-tnsncrms-xorkcit6?file=src%2Frouter.tsx

Steps to Reproduce the Bug
  1. Visit reproduction link https://stackblitz.com/edit/github-tnsncrms-xorkcit6?file=src%2Frouter.tsx
  2. Click the link in the landing page to navigate to /test?tags=1,2
  3. Observe "redirected you too many times" error in browser and document response:
   HTTP/1.1 307
   Location: /test?tags=1,2

Reproducible with curl:
4. Open new terminal in sandbox
5. Run curl -sL --max-redirs 3 'http://localhost:3000/test?tags=1,2'
6. Observe curl exits with: curl: (47) Maximum (3) redirects followed

Expected behavior

The request should converge—ideally return 200 for /test?tags=1,2; at minimum it must not redirect to the identical public URL forever.
Equivalent encodings of a query value, such as , and %2C, should not cause a canonicalization redirect

Screenshots or Videos

No response

Platform
  • @tanstack/react-router: 1.170.45
  • @tanstack/react-start: 1.169.3
  • React: 19.3.1
  • Node: 22.16.0
  • OS: macOS 15.6 (Darwin 24.6.0)
  • Bundler: Vite 8.3.4
  • Browser: any; reproducible with curl
Additional context

getNormalizedURL rebuilds the query with URLSearchParams(...).toString(), which encodes , as %2C, before loadServerRoute compares next.publicHref with the serializer's canonical output.

Workaround:

Split parsed params by comma in stringifySearch: Request search string is ?tags=1,2, after server normalization becomes ?tags=1%2C2, in stringifySearch is is parsed into { 'tags' : '1,2' }, after splitting { 'tags' : ['1', '2'] }
This is not a proper solution, but a way to mitigate the redirect loop while keeping the functionality as close as possible. It splits already escaped characters ?tag=1%2C2,3&input=foo%2Cbar -> { tags: ['1', '2', '3'], input: ['foo', 'bar'] } which is undesired.
This workaround doesn't work when rewrite option is provided in router. In that case stringifySearch doesn't affect the publicHref which is built from the history's href (see code) and SSR enters the infinite redirect loop.

Lenguaje dominante
TypeScript
Estrellas
15.3k
Forks
1.9k
Merge medio
1 d 5 h
PR fusionados (30 d)
46

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TanStack/router

Todos los issues de TanStack/router

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.