[Bug] Focus ring invisible when the chart has an x viewport: clip-path <defs> gets visibility="hidden"

Abierto
#264 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
75/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript

Línea de trabajo

Start by reading renderSvgClip in svg-renderer.js, then compare the focus visibility loops in motion.js and svg-surface.js. Reproduce with scales.x.viewport enabled and inspect how the focus layer's keyed defs element is handled. Done when the focus ring appears with a viewport and the clip region remains intact.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Version: @tanstack/charts 1.2.0, still present in 1.4.0

What happens

With scales.x.viewport set, the default focus ring on a lineY mark doesn't show on hover. The crosshair and tooltip work. The ring's <circle> is in the DOM with visibility="visible", but nothing is drawn.

Cause

With a viewport, the focus layer gets a clip path. renderSvgClip (svg-renderer.js) writes its <defs data-ts-key="…:clip-defs"> as a keyed child of the layer:

<g class="ts-chart__focus-layer" data-ts-focus-layer="over" clip-path="url(#…)">
  <defs data-ts-key="default-focus:line-0:clip-defs" visibility="hidden">
    <clipPath id="…"><rect x="44" y="4" width="700" height="178"/></clipPath>
  </defs>
  <circle data-ts-key="line-0:…" visibility="visible" … />
</g>

paintMotionSvgFocus (motion.js) and the same loop in svg-surface.js set visibility on every [data-ts-key] descendant of the layer, by whether its key is focused. The <defs> is never focused, so it gets hidden. The <rect> inside the clipPath inherits that. Per the SVG spec, a clip path child that isn't visible doesn't contribute to the clip, so the clip region is empty and the whole layer is clipped away.

Repro
defineChart({
  marks: [lineY(data, { x: (d) => d.x, y: (d) => d.y }), crosshair({ x: true, y: false })],
  scales: { x: { scale: scaleUtc, viewport: { domain: [from, to] } }, y: { scale: scaleLinear } },
  focus: 'group-x',
})

Hover the plot: tooltip and crosshair appear, the ring doesn't. Remove viewport and the ring is back.

Suggested fix

Skip the clip definitions when painting focus visibility, e.g. leave out keys ending in :clip-defs or defs elements in the querySelectorAll("[data-ts-key]") loop. Alternatively, render the <defs> without a data-ts-key.

Workaround
[data-ts-focus-layer] > defs { visibility: visible; }

CSS outranks the presentation attribute.


Investigated with the help of an AI assistant; verified against the 1.2.0 and 1.4.0 dist.

Lenguaje dominante
TypeScript
Estrellas
870
Forks
57
Merge medio
11 h 58 min
PR fusionados (30 d)
18

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TanStack/charts

Todos los issues de TanStack/charts

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.