Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

bug(tooltip): Popover portal does not reset UA border, background, and backdrop when using custom tooltip bodies

Cerrado
  • ¿Algo no está bien?
#168 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@stybo ya está trabajando en esto.

Desde el 6/10/2026.

  • #169 de @stybo — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
20/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
html, react, typescript
Área
design, frontend

Línea de trabajo

Start with packages/charts-core/tooltip-portal.ts and tooltip.ts, where the issue identifies the popover resets and inline tooltip styles. Check how renderTooltipBody is handled and run the relevant chart-core tests, if available. Done when custom tooltip bodies no longer inherit unwanted wrapper card styles and the popover backdrop is hidden; a linked pull request is already open.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Describe the bug

When using @tanstack/charts with portal and a custom React tooltip body (renderTooltipBody), the outer container element renders an unwanted border, white/canvas background, padding, box shadow, and in some browsers a backdrop.

This happens due to two issues in packages/charts-core:

  1. Missing Popover UA Resets: In tooltip-portal.ts, when element.setAttribute("popover", "manual") is called, modern browsers apply their default User-Agent stylesheet rules for :popover-open (border: 2px solid, background-color: Canvas, padding: 0.25em) and create a ::backdrop pseudo-element. tooltip-portal.ts only sets position: fixed, margin: 0, but does not neutralize border, background, outline, padding, or ::backdrop.
  2. Hardcoded Inline Card Styles on Custom Tooltips: In tooltip.ts (createTooltip), tooltipElement.style has hardcoded inline styles (background: Canvas, border: 1px solid ..., boxShadow: ..., padding: ...). When a consumer provides their own <ChartTooltip /> component via renderTooltipBody, these high-specificity inline styles leak around the custom card, forcing users to use !important CSS overrides.
Minimal Reproduction
import { defineChart, lineY } from "@tanstack/charts";
import { Chart } from "@tanstack/charts/react/tooltip";
import { portal } from "@tanstack/charts/tooltip/portal";
import { tooltip } from "@tanstack/charts/tooltip";

const chart = defineChart({
  marks: [lineY(data, { x: "time", y: "value" })],
  tooltip: {
    portal,
    use: tooltip,
  },
});

export function TelemetryChart() {
  return (
    <Chart
      definition={chart}
      renderTooltipBody={({ points }) => (
        // Custom styled tooltip card
        <div className="rounded-lg border border-zinc-200 bg-zinc-900 p-2 text-white">
          Value: {points[0].yValue}
        </div>
      )}
    />
  );
}
Expected Behavior

When renderTooltipBody is passed, or when portal uses the HTML Popover API:

  1. The outer popover wrapper element (.ts-chart-tooltip) should act as an unstyled positioning anchor without default card borders, canvas backgrounds, or padding.
  2. The popover's ::backdrop should be hidden by default (display: none).
Actual Behavior

The custom tooltip card is wrapped in a container that displays:

  • The browser's native popover border and Canvas background color.
  • TanStack Charts' default card padding, border, and box-shadow inline styles.
Suggested Fix
  1. In tooltip-portal.ts, reset UA popover styles (border: "none", background: "transparent", padding: "0", outline: "none") and inject a backdrop reset stylesheet.
  2. In tooltip.ts, reset tooltipElement.style when custom is true (renderTooltipBody is active).

I am opening a PR with this fix.

Lenguaje dominante
TypeScript
Estrellas
842
Forks
53
Merge medio
4 h 40 min
PR fusionados (30 d)
16

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TanStack/charts

Todos los issues de TanStack/charts

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.