uid index rebuilt per check and scripts re-read outside the per-run cache
Los mantenedores suelen responder en 2 días
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 48/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- godot, typescript
- Área
- performance, tooling
Línea de trabajo
Start with src/project/files.ts:14-59 to understand the per-run read cache, then trace the listed call sites in src/scenes/validate.ts, uids.ts and scene-graph.ts. Add a projectReport test that counts fs.readFileSync calls, as suggested, and use it to check the acceptance criteria: each file is read at most once per report run and no module-global file cache remains.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
The per-run "one walk, one read" index (#87) is bypassed in three places:
- The uid index is rebuilt by each check.
- Scripts are re-read in connection and registry checks.
scene-graph.tskeeps its own process-global script cache, which is never evicted.
On a modern Godot 4.4+ project, report performs about 17.9k file reads for 6.5k files.
Where
src/scenes/validate.ts:73-76,:184,:238,:315(lazyUidIndex(root)is created separately invalidateScenes,validateProjectConfigandvalidateRegistries)src/scenes/uids.ts:16-31(buildUidIndexwalks the whole tree and reads every.tscn/.tresin full, only to use the first 512 characters)src/scenes/scene-graph.ts:148-163(scriptInfo: module-globalscriptCachekeyed by absolute path, validated by mtime and size, never evicted; onestatSyncper[connection])src/scenes/validate.ts:233,:290-297,:333,:361(project.godot,readClassNameand registry.tresfiles are read withreadFileSyncinstead ofreadSource)- Compare
src/project/files.ts:14-59
Details
Measured on a synthetic project with 3000 .gd (each with a .uid sidecar), 300 .tscn and 200 registry .tres files, with run/main_scene="uid://...":
| Read count | Files | Reads |
|---|---|---|
.uid |
3000 | 9000 |
.tscn |
300 | 1200 |
.tres |
200 | 800 |
.gd (validate-scenes) |
3000 | 5700, plus 2701 statSync calls |
readClassName reads the same script once per registry entry. Building the uid index alone costs about 1.4 s. Rebuilding it pushes report from about 22 s to about 25 s (roughly 12%).
The global scriptCache behaves differently from everything else in a long-lived MCP server. It holds entries for every project seen, and it misses edits that keep the same mtime and size.
Impact
report and project_report time grows with asset and connection counts, and is worst on Windows and network filesystems. New checks have to choose between three caching models.
Suggested fix
- Add a test that counts reads per
projectReport(spy onfs.readFileSync) and records today's number. - Memoise the uid index in the per-run index (keyed by cfg and root, like
readSource), and read only the head of.tscn/.tresfiles, or reusereadSourcecontent. - Route
scriptInfo,readClassName,project.godotand the registry.tresreads throughreadSource. Delete the module-globalscriptCache, or move it into the per-run index. - Lower the read count asserted in the step-1 test.
Acceptance criteria
- Each file is read at most once per
reportrun. - No module-global file cache remains.
Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: performance|src/scenes/validate.ts|lazyUidIndex
- Lenguaje dominante
- TypeScript
- Estrellas
- 0
- Forks
- 6
- Merge medio
- 1 d 21 h
- PR fusionados (30 d)
- 8
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de TMHSDigital/godot-correctness-mcp
-
enhancement good first issue severity: medium
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
TMHSDigital/godot-correctness-mcp#123 ·
Los mantenedores suelen responder en 2 días
-
dependencies good first issue severity: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
TMHSDigital/godot-correctness-mcp#116 ·
Los mantenedores suelen responder en 2 días
-
bug good first issue severity: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
TMHSDigital/godot-correctness-mcp#107 ·
Los mantenedores suelen responder en 2 días
-
bug good first issue severity: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
TMHSDigital/godot-correctness-mcp#106 ·
Los mantenedores suelen responder en 2 días
-
bug good first issue severity: medium
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
TMHSDigital/godot-correctness-mcp#105 ·
Los mantenedores suelen responder en 2 días
Todos los issues de TMHSDigital/godot-correctness-mcp
Issues similares
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
openclaw/openclaw#203385 · 1 comentario · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
nwverse/persona#12800 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
Los mantenedores suelen responder en 1 día
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
microsoft/playwright#44289 ·
Los mantenedores suelen responder en 1 día
-
good first issue
Dificultad 2/5 Medio día Aptitud para principiantes 65/100
Los mantenedores suelen responder en 1 día