Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Follow-up to #6676: Version-guarded delete: mixed-version owners, fallback-read faults, teardown classification, wiring test

Cerrado
#6,750 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Ya se ha fusionado un pull request relacionado.

  • #6676 de @rbuergi — fusionado

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
18/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp

Línea de trabajo

Start from the version-guarded deletion path referenced in the issue: MeshExtensions.cs around lines 4209-4211 (production wiring) and the legacy teardown branch near lines 6413-6427, plus the RideOutRecyclingLeaf handling of ShuttingDown. Each finding needs a failing test first, so begin by writing a test that drives a real guarded DeleteNodeRequest and pauses after the owner verdict. Done means the four checklist items are fixed and that test shows an own write is refused until the delete completes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug feature:node-delete sev:M

Follow-up to #6676 (review findings deferred from that pull request; Refs #6676).

  • During a roll, an old owner skips the unknown ExpectedVersion member (UnmappedMemberHandling.Skip) and answers Ok(). Use a distinct request type, or require an echoed capability and map a missing echo to Unavailable.
  • A faulting fallback storage read escapes and is classified Unknown/ValidationFailed; map it to Unavailable.
  • The blanket catch turns owner teardown into Unavailable, so RideOutRecyclingLeaf never sees ShuttingDown; classify teardown as the legacy branch does (lines 6413-6427).
  • The new tests open BeginVersionGuardedDeletion directly; removing the production wiring (MeshExtensions.cs:4209-4211) leaves them green. Drive a real guarded DeleteNodeRequest, pause after the owner verdict and assert an own write is refused until the delete completes.

These are automated-review findings, assessed from the diff and not reproduced; each needs a failing test before its fix. Deferred from the PR because CI is saturated and none of them is a security hole, data loss or a broken build/test.

Lenguaje dominante
C#
Estrellas
12
Forks
5
Merge medio
6 h 28 min
PR fusionados (30 d)
951

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Systemorph/MeshWeaver

Todos los issues de Systemorph/MeshWeaver

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.